RFR: JDK-8026773: Failing compilation in Corba does not fail the build

2014-01-17 Thread Erik Joelsson
Here is a patch which has the primary purpose of eliminating a certain makefile construct that was introduced in build-infra and used in langtools and corba. The trick was clever, but unfortunately had the drawback of the build not always failing on errors, or giving very weird error messages.

Re: RFR: JDK-8026773: Failing compilation in Corba does not fail the build

2014-01-22 Thread Erik Joelsson
After discussing this with Magnus offline and some prototyping work for the future of the jdk9 build, I changed my mind and would like to solve this in a way more similar to how the jdk build is done today. (This will eventually pave the road for a more fine grained dependency graph of the whol

Re: RFR: JDK-8026773: Failing compilation in Corba does not fail the build

2014-01-22 Thread Magnus Ihse Bursie
It looks not only good, but excellent! Thank you for fixing this! There is one old minor bug that I noticed. Now might be a good time to fix it, if you want. In GensrcLangtools.gmk, line 89, tries to count processed properties, and adds the specially treated files by adding "v1 v2 v"3. It was n

Re: RFR: JDK-8026773: Failing compilation in Corba does not fail the build

2014-01-29 Thread Erik Joelsson
On 2014-01-22 16:21, Magnus Ihse Bursie wrote: It looks not only good, but excellent! Thank you for fixing this! There is one old minor bug that I noticed. Now might be a good time to fix it, if you want. In GensrcLangtools.gmk, line 89, tries to count processed properties, and adds the specia

Re: RFR: JDK-8026773: Failing compilation in Corba does not fail the build

2014-02-04 Thread Tim Bell
Hi Erik: On 2014-01-22 16:21, Magnus Ihse Bursie wrote: It looks not only good, but excellent! Thank you for fixing this! There is one old minor bug that I noticed. Now might be a good time to fix it, if you want. In GensrcLangtools.gmk, line 89, tries to count processed properties, and adds