Re: RFR: JDK-8027584 disable ccache by default

2014-11-24 Thread Steven R. Loomis
Filed: https://bugs.openjdk.java.net/browse/JDK-8065791 On 11/13/2014 10:59 PM, Steven R. Loomis wrote: > Late to the party, but please note that the README-builds.html *still* > says that ccache is great and you should install it. Doesn't mention > *anything* about ccache being off by default or

Re: RFR: JDK-8027584 disable ccache by default

2014-11-13 Thread Steven R. Loomis
Late to the party, but please note that the README-builds.html *still* says that ccache is great and you should install it. Doesn't mention *anything* about ccache being off by default or `--enable-ccache` being needed. In fact, configure actively disables ccache if you use a symlink to ccache fo

Re: RFR: JDK-8027584 disable ccache by default

2014-01-29 Thread Magnus Ihse Bursie
On 2014-01-29 11:07, David Holmes wrote: Yeah but who reads that part? :) When I do -h I'm looking for a particular option and just skim through. :) I would have naively expected the help docs to be more explicit: --enable-foo Enables foo [default] --disable-foo Disables foo but instead t

Re: RFR: JDK-8027584 disable ccache by default

2014-01-29 Thread David Holmes
On 29/01/2014 7:53 PM, Magnus Ihse Bursie wrote: On 2014-01-29 10:50, David Holmes wrote: Never realized that based on what I see in the m4 files and the help text :) All good then. Standard autoconf help text says: Optional Features: --disable-option-checking ignore unrecognized --ena

Re: RFR: JDK-8027584 disable ccache by default

2014-01-29 Thread Magnus Ihse Bursie
On 2014-01-29 10:50, David Holmes wrote: Never realized that based on what I see in the m4 files and the help text :) All good then. Standard autoconf help text says: Optional Features: --disable-option-checking ignore unrecognized --enable/--with options --disable-FEATURE do n

Re: RFR: JDK-8027584 disable ccache by default

2014-01-29 Thread David Holmes
On 29/01/2014 7:32 PM, Magnus Ihse Bursie wrote: On 2014-01-29 10:03, David Holmes wrote: Hi Magnus, I don't object to ccache being off by default but I would like the --disable-ccache flag to remain otherwise I will have to edit a bunch of build scripts and will need different versions for 9

Re: RFR: JDK-8027584 disable ccache by default

2014-01-29 Thread Magnus Ihse Bursie
On 2014-01-29 10:03, David Holmes wrote: Hi Magnus, I don't object to ccache being off by default but I would like the --disable-ccache flag to remain otherwise I will have to edit a bunch of build scripts and will need different versions for 9 vs 8. So please maintain backward compatibility

Re: RFR: JDK-8027584 disable ccache by default

2014-01-29 Thread Erik Joelsson
On 2014-01-29 10:03, David Holmes wrote: Hi Magnus, I don't object to ccache being off by default but I would like the --disable-ccache flag to remain otherwise I will have to edit a bunch of build scripts and will need different versions for 9 vs 8. So please maintain backward compatibility

Re: RFR: JDK-8027584 disable ccache by default

2014-01-29 Thread Dmitry Samersoff
Magnus, Glad to see ccache turned off by default but I'm second to David. Please, keep --disable-ccache flag -Dmitry On 2014-01-29 13:03, David Holmes wrote: > Hi Magnus, > > I don't object to ccache being off by default but I would like the > --disable-ccache flag to remain otherwise I will h

Re: RFR: JDK-8027584 disable ccache by default

2014-01-29 Thread David Holmes
Hi Magnus, I don't object to ccache being off by default but I would like the --disable-ccache flag to remain otherwise I will have to edit a bunch of build scripts and will need different versions for 9 vs 8. So please maintain backward compatibility here. Aside: it would make most sense to

Re: RFR: JDK-8027584 disable ccache by default

2014-01-28 Thread Mike Duigou
On Jan 28 2014, at 17:50 , Magnus Ihse Bursie wrote: > > On 2014-01-29 01:44, Mike Duigou wrote: >> Looks fine. (I have been caught by the Windows cygwin issue as well). >> >> Do you want to do away with the performance hints entirely? I had another >> patch for setting memsize which added o

Re: RFR: JDK-8027584 disable ccache by default

2014-01-28 Thread Magnus Ihse Bursie
On 2014-01-29 01:44, Mike Duigou wrote: Looks fine. (I have been caught by the Windows cygwin issue as well). Do you want to do away with the performance hints entirely? I had another patch for setting memsize which added other hints. Yes, I thought we should remove it entirely. I've heard peo

Re: RFR: JDK-8027584 disable ccache by default

2014-01-28 Thread Tim Bell
Hi Magnus: Bug: https://bugs.openjdk.java.net/browse/JDK-8027584 While ccache can be used to speed up recompilations, there are also several issues with ccache. Old versions does not work correctly for the jdk (we try to detect that). It does not work well on other platforms than Linux; on W

Re: RFR: JDK-8027584 disable ccache by default

2014-01-28 Thread Mike Duigou
Looks fine. (I have been caught by the Windows cygwin issue as well). Do you want to do away with the performance hints entirely? I had another patch for setting memsize which added other hints. Mike On Jan 28 2014, at 15:31 , Magnus Ihse Bursie wrote: > Bug: https://bugs.openjdk.java.net/br

RFR: JDK-8027584 disable ccache by default

2014-01-28 Thread Magnus Ihse Bursie
Bug: https://bugs.openjdk.java.net/browse/JDK-8027584 While ccache can be used to speed up recompilations, there are also several issues with ccache. Old versions does not work correctly for the jdk (we try to detect that). It does not work well on other platforms than Linux; on Windows it doe