Re: RFR: JDK-8029512 : webrev.ksh: fix parsing of parent repo paths from hgrc file

2014-01-08 Thread Dave Pointon
Hiya Mike , On Tue, 2014-01-07 at 09:35 -0800, Mike Duigou wrote: On Jan 7 2014, at 03:46 , Dave Pointon dpoin...@linux.vnet.ibm.com wrote: snip Thanks for the correction. My tests didn't require the filter stage so I failed to notice that this typo had crept in. No probs - that's what

Re: RFR: JDK-8029512 : webrev.ksh: fix parsing of parent repo paths from hgrc file

2014-01-07 Thread Erik Joelsson
Looks good to me. /Erik On 2014-01-07 04:45, Mike Duigou wrote: I have updated my previous webrev to make the regular expressions simpler and more portable based on feedback. I have tested on Mac, Solaris, Linux and Cygwin. http://cr.openjdk.java.net/~mduigou/JDK-8029512/1/webrev/ I did

Re: RFR: JDK-8029512 : webrev.ksh: fix parsing of parent repo paths from hgrc file

2014-01-07 Thread Dave Pointon
Hi Mike , On Mon, 2014-01-06 at 19:45 -0800, Mike Duigou wrote: I have updated my previous webrev to make the regular expressions simpler and more portable based on feedback. I have tested on Mac, Solaris, Linux and Cygwin. http://cr.openjdk.java.net/~mduigou/JDK-8029512/1/webrev/ I

Re: RFR: JDK-8029512 : webrev.ksh: fix parsing of parent repo paths from hgrc file

2014-01-07 Thread Mike Duigou
On Jan 7 2014, at 03:46 , Dave Pointon dpoin...@linux.vnet.ibm.com wrote: Hi Mike , On Mon, 2014-01-06 at 19:45 -0800, Mike Duigou wrote: I have updated my previous webrev to make the regular expressions simpler and more portable based on feedback. I have tested on Mac, Solaris, Linux

Re: RFR: JDK-8029512 : webrev.ksh: fix parsing of parent repo paths from hgrc file

2014-01-06 Thread Mike Duigou
I have updated my previous webrev to make the regular expressions simpler and more portable based on feedback. I have tested on Mac, Solaris, Linux and Cygwin. http://cr.openjdk.java.net/~mduigou/JDK-8029512/1/webrev/ I did also note that the hgrc format allows for definitions of the form:

Re: RFR: JDK-8029512 : webrev.ksh: fix parsing of parent repo paths from hgrc file

2013-12-04 Thread Erik Joelsson
Hello Mike, I think sed on some platforms doesn't support the [[:space:]] expression. I tried the line on a Solaris machine and it didn't work. /Erik On 2013-12-04 06:16, Mike Duigou wrote: Hello all; This change addresses a problem discovered by Dave Pointon.

Re: RFR: JDK-8029512 : webrev.ksh: fix parsing of parent repo paths from hgrc file

2013-12-04 Thread Dave Pointon
On Wed, 2013-12-04 at 10:45 +0100, Erik Joelsson wrote: Hello Mike, I think sed on some platforms doesn't support the [[:space:]] expression. I tried the line on a Solaris machine and it didn't work. /Erik snip I concur with you Erik, character classes are only proven to work with/in

Re: RFR: JDK-8029512 : webrev.ksh: fix parsing of parent repo paths from hgrc file

2013-12-04 Thread Dave Pointon
Oooops , On Wed, 2013-12-04 at 11:48 +, Dave Pointon wrote: snip I concur with you Erik, character classes are only proven to work with/in perl 5 across all platforms. I suggest that the need to parse whitespace can be eliminated entirely by using awk(1) with a field-delimiter of '='

Re: RFR: JDK-8029512 : webrev.ksh: fix parsing of parent repo paths from hgrc file

2013-12-04 Thread Kelly O'Hair
Or maybe tr -d '[:space:]' ??? -kto On Dec 4, 2013, at 3:48 AM, Dave Pointon wrote: On Wed, 2013-12-04 at 10:45 +0100, Erik Joelsson wrote: Hello Mike, I think sed on some platforms doesn't support the [[:space:]] expression. I tried the line on a Solaris machine and it didn't

Re: RFR: JDK-8029512 : webrev.ksh: fix parsing of parent repo paths from hgrc file

2013-12-04 Thread Dave Pointon
On Wed, 2013-12-04 at 08:51 -0800, Kelly O'Hair wrote: Or maybe tr -d '[:space:]' ??? -kto snip Hmmm, not unsurprisingly, that character class usage doesn't work on Solaris either ... $ uname -a ; echo a b c | tr -d '[:space:]' ; echo a b c | tr -d ' ' SunOS duke.hursley.ibm.com

Re: RFR: JDK-8029512 : webrev.ksh: fix parsing of parent repo paths from hgrc file

2013-12-04 Thread Mike Duigou
On Dec 4 2013, at 09:25 , Dmitry Samersoff dmitry.samers...@oracle.com wrote: Mike, Do you thing hg path default and hg path default-push is still buggy? I think it's better to use hg when possible. I suspect the bug was fixed at some point (It works on the 2.2 and 1.9 versions I tried)

Re: RFR: JDK-8029512 : webrev.ksh: fix parsing of parent repo paths from hgrc file

2013-12-04 Thread Mike Duigou
OK, I will revise to use a variant of this awk line. Mike On Dec 4 2013, at 04:28 , Dave Pointon dpoin...@linux.vnet.ibm.com wrote: Oooops , On Wed, 2013-12-04 at 11:48 +, Dave Pointon wrote: snip I concur with you Erik, character classes are only proven to work with/in perl 5

RFR: JDK-8029512 : webrev.ksh: fix parsing of parent repo paths from hgrc file

2013-12-03 Thread Mike Duigou
Hello all; This change addresses a problem discovered by Dave Pointon. http://cr.openjdk.java.net/~mduigou/JDK-8029512/0/webrev/ If the .hg/hgrc file contains (perfectly legal) spaces around the = sign of an assignment then the current script will fail to correctly read the path definition.