Re: RFR: JDK-8031759 Configure should handle overrides of tools better

2014-01-29 Thread Erik Joelsson
Looks good to me. /Erik On 2014-01-29 00:37, Magnus Ihse Bursie wrote: - BASIC_PATH_PROGS(READELF, [readelf greadelf]) seems reversed from the normal case where "g" version of a tool is preferred if available. Ok, I fix that. I noted that too but didn't change it. But I agree that preferring

Re: RFR: JDK-8031759 Configure should handle overrides of tools better

2014-01-29 Thread Erik Joelsson
On 2014-01-28 22:43, Mike Duigou wrote: - there are tools which are conditionally required on specific platforms but a few which are "# These are not required on all platforms". Should these perhaps be put into conditional blocks and required on the platforms they are needed or are they truly

Re: RFR: JDK-8031759 Configure should handle overrides of tools better

2014-01-28 Thread Magnus Ihse Bursie
- BASIC_PATH_PROGS(READELF, [readelf greadelf]) seems reversed from the normal case where "g" version of a tool is preferred if available. Ok, I fix that. I noted that too but didn't change it. But I agree that preferring the "g" version seems reasonable. (Given that we trust GNU tools more th

Re: RFR: JDK-8031759 Configure should handle overrides of tools better

2014-01-28 Thread Magnus Ihse Bursie
On 2014-01-28 22:43, Mike Duigou wrote: I really prefer the enhanced semantics! Thanks! - another non-autoconf option to configure to force regeneration of generated-configure would be nice. ("--force-autogen" perhaps?) Applying patches (such as this one) I sometimes find that the timestamp

Re: RFR: JDK-8031759 Configure should handle overrides of tools better

2014-01-28 Thread Mike Duigou
I really prefer the enhanced semantics! - another non-autoconf option to configure to force regeneration of generated-configure would be nice. ("--force-autogen" perhaps?) Applying patches (such as this one) I sometimes find that the timestamp check gets confused and fails to regen. "touch comm

Re: RFR: JDK-8031759 Configure should handle overrides of tools better

2014-01-28 Thread Tim Bell
Magnus: Okay, so here's the revised version. What's new this time: * Overriding of tools is only supported on the command line. If user types e.g. "CAT=miaow configure", this will result in a warning (and cat being detected normally). "configure CAT=/bin/woof", otoh, will use the provided va

Re: RFR: JDK-8031759 Configure should handle overrides of tools better

2014-01-28 Thread Magnus Ihse Bursie
On 2014-01-22 16:29, Magnus Ihse Bursie wrote: Sure, I forgot about the greadlink addition. I'll fix that. Also, your comment got me wondering if this is the wrong solution after all. We have tried hard to stay clear of letting environment variables affect the build, since they are "invisible"

Re: RFR: JDK-8031759 Configure should handle overrides of tools better

2014-01-27 Thread Magnus Ihse Bursie
On 2014-01-27 09:26, Dave Pointon wrote: Hi Magnus , On Wed, 2014-01-22 at 16:29 +0100, Magnus Ihse Bursie wrote: Sure, I forgot about the greadlink addition. I'll fix that. Also, your comment got me wondering if this is the wrong solution after all. We have tried hard to stay clear of letti

Re: RFR: JDK-8031759 Configure should handle overrides of tools better

2014-01-27 Thread Dave Pointon
Hi Magnus , On Wed, 2014-01-22 at 16:29 +0100, Magnus Ihse Bursie wrote: > Sure, I forgot about the greadlink addition. I'll fix that. > > Also, your comment got me wondering if this is the wrong solution after all. > We have tried hard to stay clear of letting environment variables affect the

Re: RFR: JDK-8031759 Configure should handle overrides of tools better

2014-01-22 Thread Magnus Ihse Bursie
Sure, I forgot about the greadlink addition. I'll fix that. Also, your comment got me wondering if this is the wrong solution after all. We have tried hard to stay clear of letting environment variables affect the build, since they are "invisible", impossible to check and creates hard to debug

Re: RFR: JDK-8031759 Configure should handle overrides of tools better

2014-01-21 Thread Mike Duigou
The change works for me and does meet the needs I was trying to address in 8031669. Could you include the addition of [greadlink readlink] that was in my patch? The Mac version of this tool from either fink or macports is named greadlink and has advantages over the manual resolution method (mos

RFR: JDK-8031759 Configure should handle overrides of tools better

2014-01-20 Thread Magnus Ihse Bursie
Bug: https://bugs.openjdk.java.net/browse/JDK-8031759 In a way, this is a continuation of JDK-8022411. While that bug fixed the ability to properly override CC/CXX with either a complete path, or just a command name that was to be searched in $PATH, this fix does the same for all other tools t