Hello David,
Actually no, that wouldn't fit the model we are aiming for. In make/src
we put source for build tools, that are only used during the build to
generate things for the product. In make/data we put data files that are
input to build tools. We leave template java files in the main sou
Maybe too late but ...
On 12/02/2014 7:55 PM, Erik Joelsson wrote:
New webrev: http://cr.openjdk.java.net/~erikj/8034179/webrev.jdk.02/
* Moved into fs and ch subdirectories.
* Cleaned up the logic in GensrcMisc.gmk
Given you've moved stuff from src to make/src wouldn't it also make
sense to
Looks good to me.
/Magnus
> On 12 feb 2014, at 10:55, Erik Joelsson wrote:
>
> New webrev: http://cr.openjdk.java.net/~erikj/8034179/webrev.jdk.02/
>
> * Moved into fs and ch subdirectories.
> * Cleaned up the logic in GensrcMisc.gmk
>
> /Erik
>
>> On 2014-02-11 14:53, Alan Bateman wrote:
>
On 12/02/2014 09:55, Erik Joelsson wrote:
New webrev: http://cr.openjdk.java.net/~erikj/8034179/webrev.jdk.02/
* Moved into fs and ch subdirectories.
* Cleaned up the logic in GensrcMisc.gmk
/Erik
Thanks for the update, it looks good to me.
-Alan
New webrev: http://cr.openjdk.java.net/~erikj/8034179/webrev.jdk.02/
* Moved into fs and ch subdirectories.
* Cleaned up the logic in GensrcMisc.gmk
/Erik
On 2014-02-11 14:53, Alan Bateman wrote:
On 11/02/2014 11:31, Erik Joelsson wrote:
Here is a second patch for cleaning up gensrc tools sour
On 11/02/2014 11:31, Erik Joelsson wrote:
Here is a second patch for cleaning up gensrc tools source. This time
it's nio related.
* Move genUnixConstants.c, genSolarisConstants.c and
genSocketOptionRegistry.c to make/src/native/...
* Rename pregenerated versions of these generated files to
*.
On 2014-02-11 12:31, Erik Joelsson wrote:
Here is a second patch for cleaning up gensrc tools source. This time
it's nio related.
* Move genUnixConstants.c, genSolarisConstants.c and
genSocketOptionRegistry.c to make/src/native/...
* Rename pregenerated versions of these generated files to
*.
Here is a second patch for cleaning up gensrc tools source. This time
it's nio related.
* Move genUnixConstants.c, genSolarisConstants.c and
genSocketOptionRegistry.c to make/src/native/...
* Rename pregenerated versions of these generated files to
*.java.template to avoid having to exclude th
