Re: RFR: JDK-8034193: Move X11 wrapper generator files to make/src and make/data

2014-02-13 Thread Magnus Ihse Bursie
On 2014-02-12 10:13, Erik Joelsson wrote: Thanks for the feedback, here is a new webrev with the directory names changed to "x11wrappergen". http://cr.openjdk.java.net/~erikj/8034193/webrev.jdk.02/ I agree that it looks better. Looks good to me. Thanks! /Magnus

Re: RFR: JDK-8034193: Move X11 wrapper generator files to make/src and make/data

2014-02-12 Thread Erik Joelsson
Thanks for the feedback, here is a new webrev with the directory names changed to "x11wrappergen". http://cr.openjdk.java.net/~erikj/8034193/webrev.jdk.02/ I agree that it looks better. /Erik On 2014-02-11 17:58, Tim Bell wrote: On 02/11/14 06:09 AM, Magnus Ihse Bursie wrote: On 2014-02-11

Re: RFR: JDK-8034193: Move X11 wrapper generator files to make/src and make/data

2014-02-11 Thread Tim Bell
On 02/11/14 06:09 AM, Magnus Ihse Bursie wrote: On 2014-02-11 14:10, Erik Joelsson wrote: Another gensrc cleanup, this time it's X11 wrappers source locations. * Moving WrapperGenerator.java to jdk/make/src/classes/... * Moving the input data files to jdk/make/data/... Bug: https://bugs.openjd

Re: RFR: JDK-8034193: Move X11 wrapper generator files to make/src and make/data

2014-02-11 Thread Magnus Ihse Bursie
On 2014-02-11 14:10, Erik Joelsson wrote: Another gensrc cleanup, this time it's X11 wrappers source locations. * Moving WrapperGenerator.java to jdk/make/src/classes/... * Moving the input data files to jdk/make/data/... Bug: https://bugs.openjdk.java.net/browse/JDK-8034193 Webrev: http://cr.o

Re: RFR: JDK-8034193: Move X11 wrapper generator files to make/src and make/data

2014-02-11 Thread Alan Bateman
On 11/02/2014 13:25, Erik Joelsson wrote: The pattern in jdk/make/src/classes/build/tools has so far been to have one directory for describing the tool. I agree that x11wrappergenerator is a bit long and we can certainly change it. Okay, it's just that it is longer and tool name gets repeated

Re: RFR: JDK-8034193: Move X11 wrapper generator files to make/src and make/data

2014-02-11 Thread Magnus Ihse Bursie
On 2014-02-11 14:25, Erik Joelsson wrote: On 2014-02-11 14:16, Alan Bateman wrote: On 11/02/2014 13:10, Erik Joelsson wrote: Another gensrc cleanup, this time it's X11 wrappers source locations. * Moving WrapperGenerator.java to jdk/make/src/classes/... * Moving the input data files to jdk/ma

Re: RFR: JDK-8034193: Move X11 wrapper generator files to make/src and make/data

2014-02-11 Thread Erik Joelsson
On 2014-02-11 14:16, Alan Bateman wrote: On 11/02/2014 13:10, Erik Joelsson wrote: Another gensrc cleanup, this time it's X11 wrappers source locations. * Moving WrapperGenerator.java to jdk/make/src/classes/... * Moving the input data files to jdk/make/data/... Bug: https://bugs.openjdk.java

Re: RFR: JDK-8034193: Move X11 wrapper generator files to make/src and make/data

2014-02-11 Thread Alan Bateman
On 11/02/2014 13:10, Erik Joelsson wrote: Another gensrc cleanup, this time it's X11 wrappers source locations. * Moving WrapperGenerator.java to jdk/make/src/classes/... * Moving the input data files to jdk/make/data/... Bug: https://bugs.openjdk.java.net/browse/JDK-8034193 Webrev: http://cr.o

RFR: JDK-8034193: Move X11 wrapper generator files to make/src and make/data

2014-02-11 Thread Erik Joelsson
Another gensrc cleanup, this time it's X11 wrappers source locations. * Moving WrapperGenerator.java to jdk/make/src/classes/... * Moving the input data files to jdk/make/data/... Bug: https://bugs.openjdk.java.net/browse/JDK-8034193 Webrev: http://cr.openjdk.java.net/~erikj/8034193/webrev.jdk.0