Hi Magnus
Looks good to me as well.
Tim
On 03/24/14 04:20, Erik Joelsson wrote:
I think it looks good overall and it's good to clean this up.
toolchain_windows.m4:
204: not your change but the typo stings my eyes and could be fixed
while in the area. (corrent?)
I wonder if it would be bett
On 2014-03-24 12:20, Erik Joelsson wrote:
I think it looks good overall and it's good to clean this up.
toolchain_windows.m4:
204: not your change but the typo stings my eyes and could be fixed
while in the area. (corrent?)
Fixed.
I wonder if it would be better to move the deletion of the tem
I think it looks good overall and it's good to clean this up.
toolchain_windows.m4:
204: not your change but the typo stings my eyes and could be fixed
while in the area. (corrent?)
I wonder if it would be better to move the deletion of the temporary
script files to later in the function so t
This bug was triggered by the issue in JDK-8035725. Had the VS detection
logic been more transparent, that bug would not have had to happen.
We need to rewrite the VS detection so that it is much more controlled,
and do not run an unchecked shell script that modifies arbitrary
environment vari