Re: RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-31 Thread Tim Bell
Hi Erik Looks good to me as well. Tim Looks good to me. /Magnus On 27 mar 2014, at 12:47, Erik Joelsson wrote: Further testing revealed some more issues. New webrev: http://cr.openjdk.java.net/~erikj/8038340/webrev.root.03/ I had to break out the devkit/sysroot parts from from BASIC_SETU

Re: RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-27 Thread Magnus Ihse Bursie
Looks good to me. /Magnus > On 27 mar 2014, at 12:47, Erik Joelsson wrote: > > Further testing revealed some more issues. New webrev: > > http://cr.openjdk.java.net/~erikj/8038340/webrev.root.03/ > > I had to break out the devkit/sysroot parts from from BASIC_SETUP_PATHS so > that it happen

Re: RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-27 Thread Erik Joelsson
Further testing revealed some more issues. New webrev: http://cr.openjdk.java.net/~erikj/8038340/webrev.root.03/ I had to break out the devkit/sysroot parts from from BASIC_SETUP_PATHS so that it happened after the early custom hook. /Erik On 2014-03-26 12:36, Magnus Ihse Bursie wrote: On

Re: RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-27 Thread Magnus Ihse Bursie
Yes, basically. And, optionally, an extra path (for non-toolchain binaries). So setting --with-devkit is, in a way, a convenient way of setting all these three options, in a way that works together and makes sense. That is, more or less, the same behavior we've had all the time, but it's slight

Re: RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-26 Thread David Holmes
On 26/03/2014 9:57 PM, Magnus Ihse Bursie wrote: On 2014-03-26 12:51, David Holmes wrote: sysroots and tool-chains and dev-kits! oh my! Seriously, what does all this mean for someone who just wants to build the OpenJDK? I use dev-kit for cross-compilation builds but I have no idea what these d

Re: RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-26 Thread Magnus Ihse Bursie
On 2014-03-26 12:51, David Holmes wrote: sysroots and tool-chains and dev-kits! oh my! Seriously, what does all this mean for someone who just wants to build the OpenJDK? I use dev-kit for cross-compilation builds but I have no idea what these different things are supposed to represent. You

Re: RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-26 Thread David Holmes
sysroots and tool-chains and dev-kits! oh my! Seriously, what does all this mean for someone who just wants to build the OpenJDK? I use dev-kit for cross-compilation builds but I have no idea what these different things are supposed to represent. David On 26/03/2014 8:32 PM, Erik Joelsson wr

Re: RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-26 Thread Magnus Ihse Bursie
On 2014-03-26 12:32, Erik Joelsson wrote: Thanks, here is a new webrev: http://cr.openjdk.java.net/~erikj/8038340/webrev.root.02/ Looks good to me. /Magnus

Re: RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-26 Thread Erik Joelsson
Thanks, here is a new webrev: http://cr.openjdk.java.net/~erikj/8038340/webrev.root.02/ /Erik On 2014-03-26 12:14, Magnus Ihse Bursie wrote: That's a lot of good changes! :-) Some comments: In basics.m4: * The description of --with-devkit is not ideal. It does more than sets sysroot and too

Re: RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-26 Thread Magnus Ihse Bursie
That's a lot of good changes! :-) Some comments: In basics.m4: * The description of --with-devkit is not ideal. It does more than sets sysroot and toolchain path (e.g. the extra path, and perhaps more things to come). Maybe just some more vague description like "use this devkit for compilers,

RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-26 Thread Erik Joelsson
Hello, (including 2d-dev/awt-dev because I'm changing linker flags on desktop libs.) In preparation for upgrading compilers and build platforms, we would like to get better separation between the two. At least on Linux and Solaris this is certainly possible. Some work for this was already do