Re: RFR: JDK-8062449 Update langtools/test/Makefile to use JCK 9

2014-10-31 Thread Dan Smith
While I'm at it, here are some trivial cleanups: - Silence echoing of the error-handling commands (command still runs, but make doesn't print it out) - Allow the 'JCK_VERBOSE' variable to request -v (JCK doesn't support this with an alias like -v:summary) Jon, if you still approve, I'll push

Re: RFR: JDK-8062449 Update langtools/test/Makefile to use JCK 9

2014-10-31 Thread Jonathan Gibbons
Dan, OK by me. -- Jon On 10/31/2014 11:28 AM, Dan Smith wrote: While I'm at it, here are some trivial cleanups: - Silence echoing of the error-handling commands (command still runs, but make doesn't print it out) - Allow the 'JCK_VERBOSE' variable to request -v (JCK doesn't support this

Re: RFR: JDK-8062449 Update langtools/test/Makefile to use JCK 9

2014-10-30 Thread Erik Joelsson
Hello Dan, The change looks good to me. I'm not a user of these tests though so perhaps best to get a langtools reviewer to look at it too. /Erik On 2014-10-29 20:41, Dan Smith wrote: Looking for a review of the following small patch to langtools/test/Makefile. The script is hard-coded to

Re: RFR: JDK-8062449 Update langtools/test/Makefile to use JCK 9

2014-10-30 Thread Jonathan Gibbons
Da, Erik, Looks good to me. --- Jon On 10/30/2014 01:27 AM, Erik Joelsson wrote: Hello Dan, The change looks good to me. I'm not a user of these tests though so perhaps best to get a langtools reviewer to look at it too. /Erik On 2014-10-29 20:41, Dan Smith wrote: Looking for a review of

RFR: JDK-8062449 Update langtools/test/Makefile to use JCK 9

2014-10-29 Thread Dan Smith
Looking for a review of the following small patch to langtools/test/Makefile. The script is hard-coded to use JCK 8 when running JCK tests, causing 19 failures; it should be using JCK 9. I assume there aren't any important processes that depend on this target (e.g., SQE automated runs) or