Hello,
Please review this build reliability fix. In JDK-8065138, we would have
caught the error much faster if the build had failed instead of silently
generating bad output. To avoid this in the future, this patch activates
pipefail and errexit in the shell, when available. This means that lo
Erik:
Please review this build reliability fix. In JDK-8065138, we would
have caught the error much faster if the build had failed instead of
silently generating bad output. To avoid this in the future, this
patch activates pipefail and errexit in the shell, when available.
This means that lo
Looks good to me too.
I appreciate the high bar for build correctness.
I would test with both make 3.81 and 4.x
On Wed, Nov 26, 2014 at 6:56 AM, Erik Joelsson wrote:
> Hello,
>
> Please review this build reliability fix. In JDK-8065138, we would have
> caught the error much faster if the build
On 2014-11-26 15:56, Erik Joelsson wrote:
Hello,
Please review this build reliability fix. In JDK-8065138, we would
have caught the error much faster if the build had failed instead of
silently generating bad output. To avoid this in the future, this
patch activates pipefail and errexit in t
Hello,
New webrev, which addresses Magnus' concern below, and various fixes in
Hotspot for incompatibilities with errexit.
Webrev: http://cr.openjdk.java.net/~erikj/8065576/webrev.02/
Bug: https://bugs.openjdk.java.net/browse/JDK-8065576
For the LOG=trace issue Magnus described below, it was
Erik:
New webrev, which addresses Magnus' concern below, and various fixes
in Hotspot for incompatibilities with errexit.
Webrev: http://cr.openjdk.java.net/~erikj/8065576/webrev.02/
Bug: https://bugs.openjdk.java.net/browse/JDK-8065576
Looks good to me.
/Tim
For the LOG=trace issue Magnu
Hiya Erik ,
In every make recipe that I've ever written, I've yet to use the '... run
command ; if test $/; then ...' structure since I always run the shell with
'-e' option enabled and if the command returns a non-zero error status,
then shell picks it up - which explains why the majority of make
On 2014-12-01 14:27, Erik Joelsson wrote:
Hello,
New webrev, which addresses Magnus' concern below, and various fixes
in Hotspot for incompatibilities with errexit.
Webrev: http://cr.openjdk.java.net/~erikj/8065576/webrev.02/
Bug: https://bugs.openjdk.java.net/browse/JDK-8065576
For the LOG
