On Fri, Jan 16, 2015 at 3:47 PM, Magnus Ihse Bursie
wrote:
> On 2015-01-15 18:33, Volker Simonis wrote:
>>
>> I'm aware that this mail degenerated more into a wish-list than a
>> review:) Maybe you find it useful nevertheless.
>
>
> It's full of good suggestions! I'll definitely try to improve th
On 2015-01-15 16:32, Erik Joelsson wrote:
Looks good to me.
Thanks. It turned out that I needed to integrate this via jdk9-client
instead of jdk9-dev, as usual, to support the upcoming build-infra work,
and to avoid an unneccessary merge clash with the changes of Visual
Studio 2012 in jdk9-c
On 2015-01-15 18:33, Volker Simonis wrote:
I'm aware that this mail degenerated more into a wish-list than a
review:) Maybe you find it useful nevertheless.
It's full of good suggestions! I'll definitely try to improve the
makefile usability based on your suggestions. But, as you say, it's a
On 2015-01-16 10:34, Volker Simonis wrote:
Aadvanced bash completion is a cool feature I wasn't aware of until
now - thanks for mentioning it.
Also, it could be worth mentioning that bash completion works with
configure as well, but with a twist. The "bash configure" call pattern
does not work
On 2015-01-16 10:34, Volker Simonis wrote:
What you can do right now, if you use bash, is activating advanced bash
completion. Then you can type "make " and tab your way through the targets,
which is what I usually do. A warning though that without typing a few
letters, you get several hundreds t
On 2015-01-16 10:34, Volker Simonis wrote:
Aadvanced bash completion is a cool feature I wasn't aware of until
now - thanks for mentioning it.
Unfortunately it doesn't seem to work out of the box on my Ubuntu
12.04. I only get:
$ make [TAB][TAB]
default Error help Makefile
Do you u
On Fri, Jan 16, 2015 at 9:31 AM, Erik Joelsson wrote:
> Hello Volker,
>
> I think I'm mostly to blame for the current state of the make help text and
> I certainly value feedback on it. I agree that talk of repos in the help
> text is just confusing at this point. The pre modules build was organiz
Hello Volker,
I think I'm mostly to blame for the current state of the make help text
and I certainly value feedback on it. I agree that talk of repos in the
help text is just confusing at this point. The pre modules build was
organized around repos and I got stuck in that thinking when I trie
Hi Magnus,
I've only had a quick look at your changes but I have a question.
When looking at the "make help" I think the relationship between
"repo", "target" and "module" is a little unclear.
As far as I understand a "target" is an artefact which can be named
and build by "make".
A "repo" is a
Looks good to me.
/Erik
On 2015-01-15 16:23, Magnus Ihse Bursie wrote:
This fix is the result of preparatory work in the build-infra
project. It includes:
* Remove duplicate detection of comm on Windows
* compare.sh enhancements and bug fixes
* Do not fail in SetupFoo macros on empty argument
This fix is the result of preparatory work in the build-infra project.
It includes:
* Remove duplicate detection of comm on Windows
* compare.sh enhancements and bug fixes
* Do not fail in SetupFoo macros on empty arguments
* Minor JavaCompilation enhancements
* Makefile warns for unknown contro
11 matches
Mail list logo