Erik
On 02/17/15 15:58, Daniel Fuchs wrote:
On 17/02/15 16:38, Erik Joelsson wrote:
Right, thanks for catching that. The OS specific file is not there for
every OS. This patch should fix it. I'm testing all platforms now.
Webrev: http://cr.openjdk.java.net/~erikj/8073328/webrev.jdk.03/
On 17/02/15 16:38, Erik Joelsson wrote:
Right, thanks for catching that. The OS specific file is not there for
every OS. This patch should fix it. I'm testing all platforms now.
Webrev: http://cr.openjdk.java.net/~erikj/8073328/webrev.jdk.03/
Thanks Erik.
This one appears to work like a
Erik, the change looks good. Thanks for following up on this one!
-Sherman
On 2/17/15 7:38 AM, Erik Joelsson wrote:
Right, thanks for catching that. The OS specific file is not there for
every OS. This patch should fix it. I'm testing all platforms now.
Webrev:
Right, thanks for catching that. The OS specific file is not there for
every OS. This patch should fix it. I'm testing all platforms now.
Webrev: http://cr.openjdk.java.net/~erikj/8073328/webrev.jdk.03/
/Erik
On 2015-02-17 16:24, Daniel Fuchs wrote:
Hi Erik,
I tried to import your patch,
I realize that I missed a couple of my own notes on the original review
for JDK-8073152. Here is an update webrev where I address those points
as well.
* Remove unused variable CHARSET_EXTENDED
* Remove use of undefined variable $(CHARSET_EXTENDED_DATA)
However, I opted not to add all the
Hello,
Please review this fix for the incremental build behavior of the gensrc
build step. After JDK-8073152 the charsets would unconditionally get
regenerated each time make was invoked. The actual culprit was a stray
backslash which prevented the 'touch' on the next line from executing.
I
On 17/02/2015 14:56, Erik Joelsson wrote:
Hello,
Please review this fix for the incremental build behavior of the
gensrc build step. After JDK-8073152 the charsets would
unconditionally get regenerated each time make was invoked. The actual
culprit was a stray backslash which prevented the
Hi Erik,
I tried to import your patch, and now the build fails with the
following error:
make[3]: *** No rule to make target
`/Users/danielfuchs/workspaces/jdk/jdk9-dev-java-time/jdk/make/data/charsetmapping/stdcs-macosx',
needed by
On 17/02/2015 15:38, Erik Joelsson wrote:
Right, thanks for catching that. The OS specific file is not there for
every OS. This patch should fix it. I'm testing all platforms now.
Webrev: http://cr.openjdk.java.net/~erikj/8073328/webrev.jdk.03/
/Erik
Updated webrev looks good.
-Alan
