On 4/06/2015 10:38 PM, Magnus Ihse Bursie wrote:
On 2015-06-04 07:41, David Holmes wrote:
Magnus,
You missed the hotspot side of this:
./solaris/makefiles/gcc.make: DEBUG_CFLAGS += -fstack-protector-all
--param ssp-buffer-size=1
./bsd/makefiles/gcc.make:DEBUG_CFLAGS +=
On 2015-06-04 07:41, David Holmes wrote:
Magnus,
You missed the hotspot side of this:
./solaris/makefiles/gcc.make: DEBUG_CFLAGS += -fstack-protector-all
--param ssp-buffer-size=1
./bsd/makefiles/gcc.make:DEBUG_CFLAGS += -fstack-protector-all
--param ssp-buffer-size=1
Magnus:
Looks good to me as well.
Tim
On 06/03/15 06:12, Erik Joelsson wrote:
Looks good to me.
/Erik
On 2015-06-03 14:33, Magnus Ihse Bursie wrote:
Not all versions of gcc support -fstack-protector. We should check
that it is accepted as an argument before adding it to the flags.
Bug:
Not all versions of gcc support -fstack-protector. We should check that
it is accepted as an argument before adding it to the flags.
Bug: https://bugs.openjdk.java.net/browse/JDK-8081692
WebRev inline:
diff --git a/common/autoconf/flags.m4 b/common/autoconf/flags.m4
---
Looks good to me.
/Erik
On 2015-06-03 14:33, Magnus Ihse Bursie wrote:
Not all versions of gcc support -fstack-protector. We should check
that it is accepted as an argument before adding it to the flags.
Bug: https://bugs.openjdk.java.net/browse/JDK-8081692
WebRev inline:
diff --git
Magnus,
You missed the hotspot side of this:
./solaris/makefiles/gcc.make: DEBUG_CFLAGS += -fstack-protector-all
--param ssp-buffer-size=1
./bsd/makefiles/gcc.make:DEBUG_CFLAGS += -fstack-protector-all
--param ssp-buffer-size=1
./linux/makefiles/gcc.make:DEBUG_CFLAGS +=
