Re: RFR: JDK-8155587: Cross compilation may cause compiler warnings for "build" compiler

2016-05-11 Thread Erik Joelsson
On 2016-05-11 08:05, David Holmes wrote: Hi Erik, Seems reasonable. flags.m4 is okay, but the toolchain.m4 changes stretch my comprehension of the overall process. As long as this gets through jprt with -testset hotspot, then I'm fine with it. :) I agree this got nasty. I was actually

Re: RFR: JDK-8155587: Cross compilation may cause compiler warnings for "build" compiler

2016-05-11 Thread David Holmes
Hi Erik, Seems reasonable. flags.m4 is okay, but the toolchain.m4 changes stretch my comprehension of the overall process. As long as this gets through jprt with -testset hotspot, then I'm fine with it. :) Thanks, David On 11/05/2016 2:41 AM, Erik Joelsson wrote: Hello, When cross

Re: RFR: JDK-8155587: Cross compilation may cause compiler warnings for "build" compiler

2016-05-10 Thread Chris Plummer
Hi Erik, I can confirm the changes resolve the issues I was having. I looked at the changes, but don't really have the background to comment on them. thanks, Chris On 5/10/16 9:41 AM, Erik Joelsson wrote: Hello, When cross compiling, we compile a subset of the jdk for the build host to

RFR: JDK-8155587: Cross compilation may cause compiler warnings for "build" compiler

2016-05-10 Thread Erik Joelsson
Hello, When cross compiling, we compile a subset of the jdk for the build host to be able to run jmod and jlink. Configure sets up a toolchain for this through variables prefixed "BUILD_" (BUILD_CC etc). The new nifty macro we have for conditionally setting compiler flags depending on the