Re: RFR: JDK-8156837: RC resource compilation on windows generates false build failure reports

2016-05-12 Thread Phil Race
+1 -phil. On 05/12/2016 11:02 AM, Tim Bell wrote: Erik: Looks good to me as well. /Tim On 05/12/16 04:06, Erik Joelsson wrote: Good point, the quotes are certainly not necessary. Removed and updated review in place. Verified that it still works. /Erik On 2016-05-12 12:49, Vadim Pakhnushe

Re: RFR: JDK-8156837: RC resource compilation on windows generates false build failure reports

2016-05-12 Thread Tim Bell
Erik: Looks good to me as well. /Tim On 05/12/16 04:06, Erik Joelsson wrote: Good point, the quotes are certainly not necessary. Removed and updated review in place. Verified that it still works. /Erik On 2016-05-12 12:49, Vadim Pakhnushev wrote: Erik, I wonder why in the Launcher-java.bas

Re: RFR: JDK-8156837: RC resource compilation on windows generates false build failure reports

2016-05-12 Thread Erik Joelsson
Good point, the quotes are certainly not necessary. Removed and updated review in place. Verified that it still works. /Erik On 2016-05-12 12:49, Vadim Pakhnushev wrote: Erik, I wonder why in the Launcher-java.base.gmk first -I flag parameter is not quoted, but subsequent flags parameters are

Re: RFR: JDK-8156837: RC resource compilation on windows generates false build failure reports

2016-05-12 Thread Vadim Pakhnushev
Erik, I wonder why in the Launcher-java.base.gmk first -I flag parameter is not quoted, but subsequent flags parameters are quoted? I guess the quotes are unnecessary here... Vadim On 12.05.2016 13:22, Erik Joelsson wrote: When using the RC tool on Windows, we also run CL with the same argumen

RFR: JDK-8156837: RC resource compilation on windows generates false build failure reports

2016-05-12 Thread Erik Joelsson
When using the RC tool on Windows, we also run CL with the same arguments to generate dependencies on included files. In some cases, extra include directories are provided in the RC_FLAGS, using the flag -i (lower case). This flag works for the RC tool, but not for CL, which requires -I (upper