Re: RFR: JDK-8164120: The minimal VM should be stripped using --strip-unneeded

2016-10-04 Thread Magnus Ihse Bursie
On 2016-10-04 11:30, Erik Joelsson wrote: That was intended but I discovered that the whole thing was wrong. The default strip flag we use on Linux "-g" and the new flag we set for minimal "--strip-unneeded" are the mutually exclusive, so whatever ends up last on the command line wins. Since th

Re: RFR: JDK-8164120: The minimal VM should be stripped using --strip-unneeded

2016-10-04 Thread Erik Joelsson
That was intended but I discovered that the whole thing was wrong. The default strip flag we use on Linux "-g" and the new flag we set for minimal "--strip-unneeded" are the mutually exclusive, so whatever ends up last on the command line wins. Since the new flag is an override, we should treat

Re: RFR: JDK-8164120: The minimal VM should be stripped using --strip-unneeded

2016-10-04 Thread David Holmes
Hi Erik, On 3/10/2016 11:53 PM, Erik Joelsson wrote: (adding hotspot-dev) On 2016-10-03 15:52, Erik Joelsson wrote: Hello, Please review this small change, which adds --strip-unneeded when stripping the minimal VM on Linux, which reduces size on x86 builds with around 1.2MB. Bug: https://bu

Re: RFR: JDK-8164120: The minimal VM should be stripped using --strip-unneeded

2016-10-04 Thread Magnus Ihse Bursie
On 2016-10-03 15:52, Erik Joelsson wrote: Hello, Please review this small change, which adds --strip-unneeded when stripping the minimal VM on Linux, which reduces size on x86 builds with around 1.2MB. Bug: https://bugs.openjdk.java.net/browse/JDK-8164120 Webrev: http://cr.openjdk.java.net/

Re: RFR: JDK-8164120: The minimal VM should be stripped using --strip-unneeded

2016-10-03 Thread Tim Bell
Erik - Looks good to me as well. /Tim On 10/03/16 07:11, Bob Vandette wrote: The change looks good to me. Bob. On Oct 3, 2016, at 9:52 AM, Erik Joelsson wrote: Hello, Please review this small change, which adds --strip-unneeded when stripping the minimal VM on Linux, which reduces size

Re: RFR: JDK-8164120: The minimal VM should be stripped using --strip-unneeded

2016-10-03 Thread Bob Vandette
The change looks good to me. Bob. > On Oct 3, 2016, at 9:52 AM, Erik Joelsson wrote: > > Hello, > > Please review this small change, which adds --strip-unneeded when stripping > the minimal VM on Linux, which reduces size on x86 builds with around 1.2MB. > > Bug: https://bugs.openjdk.java.ne

Re: RFR: JDK-8164120: The minimal VM should be stripped using --strip-unneeded

2016-10-03 Thread Erik Joelsson
(adding hotspot-dev) On 2016-10-03 15:52, Erik Joelsson wrote: Hello, Please review this small change, which adds --strip-unneeded when stripping the minimal VM on Linux, which reduces size on x86 builds with around 1.2MB. Bug: https://bugs.openjdk.java.net/browse/JDK-8164120 Webrev: http

RFR: JDK-8164120: The minimal VM should be stripped using --strip-unneeded

2016-10-03 Thread Erik Joelsson
Hello, Please review this small change, which adds --strip-unneeded when stripping the minimal VM on Linux, which reduces size on x86 builds with around 1.2MB. Bug: https://bugs.openjdk.java.net/browse/JDK-8164120 Webrev: http://cr.openjdk.java.net/~erikj/8164120/webrev.hotspot.01/ /Erik