Re: RFR: JDK-8171310: Gtest libjvm.so is always stripped

On 2016-12-15 21:29, Thomas Stüfe wrote: Short question, how do you generate and apply a webrev patch spanning multiple forest branches? If you have the trees extension, there is a parameter to webrev, "-f" (for forest, historical reasons..) that does this. /Erik

Re: RFR: JDK-8171310: Gtest libjvm.so is always stripped

Hi Erik, Seems reasonable/logical. :) Thanks, David On 16/12/2016 1:01 AM, Erik Joelsson wrote: Hello, Please review this patch, which fixes stripping behavior in the build. In JDK-8150736 I reworked the general handling of debug symbols. My intention then was to always leave debug symbols

Re: RFR: JDK-8171310: Gtest libjvm.so is always stripped

Erik, On Thu, Dec 15, 2016 at 4:01 PM, Erik Joelsson wrote: > Hello, > > Please review this patch, which fixes stripping behavior in the build. In > JDK-8150736 I reworked the general handling of debug symbols. My intention > then was to always leave debug symbols in

Re: RFR: JDK-8171310: Gtest libjvm.so is always stripped

Erik: Please review this patch, which fixes stripping behavior in the build. In JDK-8150736 I reworked the general handling of debug symbols. My intention then was to always leave debug symbols in gtest libjvm.so as well as all other test binaries. It seems I forgot to set this for gtest

RFR: JDK-8171310: Gtest libjvm.so is always stripped

Hello, Please review this patch, which fixes stripping behavior in the build. In JDK-8150736 I reworked the general handling of debug symbols. My intention then was to always leave debug symbols in gtest libjvm.so as well as all other test binaries. It seems I forgot to set this for gtest