Re: RFR: JDK-8175824 Adapt javadoc generation to different requirements for JDK and JavaSE

2017-05-22 Thread Mandy Chung
> On May 22, 2017, at 1:31 AM, Magnus Ihse Bursie > wrote: > > Updated version: > > http://cr.openjdk.java.net/~ihse/JDK-8175824-javadoc-dynamic-overview-and-groups/webrev.02 207 This is a list of all modules included in the $$($1_FULL_NAME) API

Re: RFR: JDK-8175824 Adapt javadoc generation to different requirements for JDK and JavaSE

2017-05-22 Thread Erik Joelsson
Looks good to me. /Erik On 2017-05-22 10:31, Magnus Ihse Bursie wrote: On 2017-05-19 17:09, Mandy Chung wrote: Magnus, Iris and Kevin provides the description for each group. The overview page can look like this: This document is the Java™ Platform, Standard Edition Development Kit

Re: RFR: JDK-8175824 Adapt javadoc generation to different requirements for JDK and JavaSE

2017-05-22 Thread Magnus Ihse Bursie
On 2017-05-19 17:09, Mandy Chung wrote: Magnus, Iris and Kevin provides the description for each group. The overview page can look like this: This document is the Java™ Platform, Standard Edition Development Kit (JDK™) 9 API Specification. Java SE The Java Platform, Standard

Re: RFR: JDK-8175824 Adapt javadoc generation to different requirements for JDK and JavaSE

2017-05-22 Thread Magnus Ihse Bursie
On 2017-05-19 13:10, Erik Joelsson wrote: Looks good. Minor nit. There are variables named JavaSE_MODULES as well as JAVASE_MODULES which can be a bit confusing. Perhaps the latter can be inlined at this point? Or the first should perhaps be called JavaSE_GROUP_MODULES? I agree, that was

Re: RFR: JDK-8175824 Adapt javadoc generation to different requirements for JDK and JavaSE

2017-05-19 Thread Mandy Chung
Magnus, Iris and Kevin provides the description for each group. The overview page can look like this: This document is the Java™ Platform, Standard Edition Development Kit (JDK™) 9 API Specification. Java SE The Java Platform, Standard Edition (“Java SE”) APIs define the

Re: RFR: JDK-8175824 Adapt javadoc generation to different requirements for JDK and JavaSE

2017-05-19 Thread Erik Joelsson
Looks good. Minor nit. There are variables named JavaSE_MODULES as well as JAVASE_MODULES which can be a bit confusing. Perhaps the latter can be inlined at this point? Or the first should perhaps be called JavaSE_GROUP_MODULES? /Erik On 2017-05-19 11:28, Magnus Ihse Bursie wrote: javadoc

RFR: JDK-8175824 Adapt javadoc generation to different requirements for JDK and JavaSE

2017-05-19 Thread Magnus Ihse Bursie
javadoc allows a file to be specified to provide content for the top level "overview" page. As we move towards a unified docs bundle, we need to be able to vary the content of that file depending on the content of the bundle. This does not mean providing or including lists of modules, but