Re: RFR: JDK-8176172: Imported FX modules have have residual_imported.marker file

2017-03-07 Thread Mandy Chung
This fix looks okay. Mandy > On Mar 7, 2017, at 12:51 AM, Erik Joelsson wrote: > > Hello, > > The jmods for the imported javafx modules end up with _imported.marker files > in them. The root cause of this issue is that we don't have a coherent naming > scheme for our touch/marker files in th

Re: RFR: JDK-8176172: Imported FX modules have have residual_imported.marker file

2017-03-07 Thread Alan Bateman
As a short term solution then this looks okay to me. -Alan On 07/03/2017 08:51, Erik Joelsson wrote: Hello, The jmods for the imported javafx modules end up with _imported.marker files in them. The root cause of this issue is that we don't have a coherent naming scheme for our touch/marker

Re: RFR: JDK-8176172: Imported FX modules have have residual_imported.marker file

2017-03-07 Thread Magnus Ihse Bursie
Looks good to me. /Magnus On 2017-03-07 09:51, Erik Joelsson wrote: Hello, The jmods for the imported javafx modules end up with _imported.marker files in them. The root cause of this issue is that we don't have a coherent naming scheme for our touch/marker files in the build. I have filed

RFR: JDK-8176172: Imported FX modules have have residual_imported.marker file

2017-03-07 Thread Erik Joelsson
Hello, The jmods for the imported javafx modules end up with _imported.marker files in them. The root cause of this issue is that we don't have a coherent naming scheme for our touch/marker files in the build. I have filed JDK-8176264 to address this properly. For the immediate problem I inst