Re: RFR: JDK-8179556 Add specs copyright file

2017-06-16 Thread Erik Joelsson
Looks good to me. /Erik On 2017-06-16 11:30, Magnus Ihse Bursie wrote: Apparently these files should reside in the closed repo instead... Now there's yet another version of this patch, this time with trivial changes to open only:

Re: RFR: JDK-8179556 Add specs copyright file

2017-06-14 Thread Roger Riggs
Hi, This change looks ok, I have some other links to the copyright.html to fix in serialization and can fix the tools/docs/docs-bundle-page at the same time. Roger On 6/12/17 12:19 PM, Mandy Chung wrote: jdk/make/src/classes/build/tools/docs/docs-bundle-page.html has a reference to

Re: RFR: JDK-8179556 Add specs copyright file

2017-06-12 Thread Erik Joelsson
Still looks good to me. /Erik On 2017-06-12 09:28, Magnus Ihse Bursie wrote: Hi, This patch, while approved by reviewers, was put on hold due to legal reasons. Here's a new patch, with updated legalese. http://cr.openjdk.java.net/~ihse/JDK-8179556-add-legal-copyright-html/webrev.02

Re: RFR: JDK-8179556 Add specs copyright file

2017-06-12 Thread Magnus Ihse Bursie
Hi, This patch, while approved by reviewers, was put on hold due to legal reasons. Here's a new patch, with updated legalese. http://cr.openjdk.java.net/~ihse/JDK-8179556-add-legal-copyright-html/webrev.02 /Magnus On 2017-05-03 16:02, Magnus Ihse Bursie wrote: The new $module/specs

Re: RFR: JDK-8179556 Add specs copyright file

2017-05-03 Thread Mandy Chung
Looks good. Mandy > On May 3, 2017, at 7:02 AM, Magnus Ihse Bursie > wrote: > > The new $module/specs specifications needs to point to a proper copyright > file. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8179556 > WebRev: >

Re: RFR: JDK-8179556 Add specs copyright file

2017-05-03 Thread Erik Joelsson
Looks good. /Erik On 2017-05-03 07:02, Magnus Ihse Bursie wrote: The new $module/specs specifications needs to point to a proper copyright file. Bug: https://bugs.openjdk.java.net/browse/JDK-8179556 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8179556-add-legal-copyright-html/webrev.01

RFR: JDK-8179556 Add specs copyright file

2017-05-03 Thread Magnus Ihse Bursie
The new $module/specs specifications needs to point to a proper copyright file. Bug: https://bugs.openjdk.java.net/browse/JDK-8179556 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8179556-add-legal-copyright-html/webrev.01 /Magnus