Re: RFR: JDK-8179892 Update build documentation for JDK 9

2017-06-30 Thread Stuart Monteith
Hi, It's good to see updated documentation - a project always feels a bit stale if its documentation is out of date. However, I'd appreciate it if Derek White's issue could be addressed: "JDK-8182733: aarch64 build documentation misleading" https://bugs.openjdk.java.net/browse/JDK-8182733 Open

Re: RFR: JDK-8179892 Update build documentation for JDK 9

2017-06-22 Thread Volker Simonis
On Wed, Jun 21, 2017 at 12:59 PM, Magnus Ihse Bursie wrote: > On 2017-06-21 09:02, Thomas Stüfe wrote: >> >> Hi Magnus, >> >> excellent work! > > > Thank you! :-) > >> Some minor remarks: >> >> You also mentioned Cygwin hg in the "Special considerations" section. >> However, because updating Cygwi

Re: RFR: JDK-8179892 Update build documentation for JDK 9

2017-06-21 Thread Martin Buchholz
Thanks! On debian-based systems, it's useful to get dependencies using sudo apt-get -y build-dep openjdk-8-jdk even when building jdk9 or jdk10

Re: RFR: JDK-8179892 Update build documentation for JDK 9

2017-06-21 Thread Thomas Stüfe
I agree with Eric that it looks fine enough as it is now, and that any subsequent additions (e.g. AIX related infos) can be added later as separate changes. Happy Vacation! ..Thomas On Wed, Jun 21, 2017 at 12:59 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > On 2017-06-21 09:0

Re: RFR: JDK-8179892 Update build documentation for JDK 9

2017-06-21 Thread dalibor topic
On 21.06.2017 02:46, Magnus Ihse Bursie wrote: Also known as: "!!! THIS IS A MAJOR RE-WRITE of this document. !" :-) It is also very good. Thank you. ;) cheers, dalibor topic -- Dalibor Topic | Principal Product Manager Phone: +494089091214 | M

Re: RFR: JDK-8179892 Update build documentation for JDK 9

2017-06-21 Thread Magnus Ihse Bursie
On 2017-06-21 09:02, Thomas Stüfe wrote: Hi Magnus, excellent work! Thank you! :-) Some minor remarks: You also mentioned Cygwin hg in the "Special considerations" section. However, because updating Cygwin is a bit of a pain (you need to close all consoles to do this) it may make sense to

Re: RFR: JDK-8179892 Update build documentation for JDK 9

2017-06-21 Thread Magnus Ihse Bursie
On 2017-06-21 10:07, Erik Joelsson wrote: Wow, this is massive, and very good! Thanks you. It's been in the making for a long time, and I almost didn't get to complete it in time for JDK 9. IMO, we should just push this as is and handle any updates/corrections as followups. Otherwise we ris

Re: RFR: JDK-8179892 Update build documentation for JDK 9

2017-06-21 Thread Erik Joelsson
Wow, this is massive, and very good! IMO, we should just push this as is and handle any updates/corrections as followups. Otherwise we risk not getting this in at all. Looks good enough to me. /Erik On 2017-06-21 02:46, Magnus Ihse Bursie wrote: Also known as: "!!! THIS IS A MAJ

Re: RFR: JDK-8179892 Update build documentation for JDK 9

2017-06-21 Thread Thomas Stüfe
Hi Magnus, excellent work! Some minor remarks: You also mentioned Cygwin hg in the "Special considerations" section. However, because updating Cygwin is a bit of a pain (you need to close all consoles to do this) it may make sense to move the "Install Cygwin and all required packages" up to the b

RFR: JDK-8179892 Update build documentation for JDK 9

2017-06-20 Thread Magnus Ihse Bursie
Also known as: "!!! THIS IS A MAJOR RE-WRITE of this document. !" :-) The build documentation has been in need of an overhaul for a very long time. The document is not very well structured, and contains not only outdated but also irrelevant information, all the while va