RFR: JDK-8195689 Remove generated-configure.sh and instead use autoconf

2018-01-18 Thread Magnus Ihse Bursie
Currently, we require all developers who modify the configure script to run autoconf locally, to update the generated-configure.sh script, which is then checked in. This is the only instance of checked in "compiled" code in OpenJDK, and this has brought along several problems: * Only a specifi

Re: RFR: JDK-8195689 Remove generated-configure.sh and instead use autoconf

2018-01-18 Thread Severin Gehwolf
On Thu, 2018-01-18 at 14:28 +0100, Magnus Ihse Bursie wrote: > Currently, we require all developers who modify the configure script to > run autoconf locally, to update the generated-configure.sh script, which > is then checked in. This is the only instance of checked in "compiled" > code in Ope

Re: RFR: JDK-8195689 Remove generated-configure.sh and instead use autoconf

2018-01-18 Thread Jonathan Gibbons
On 1/18/18 5:28 AM, Magnus Ihse Bursie wrote: * Only a specific version of autoconf, 2.69, can be used, to avoid large code changes in the generated file. Unfortunately, Ubuntu ships a version of autoconf that claims to be 2.69 but is actually heavily patched. This requires all Ubuntu users

Re: RFR: JDK-8195689 Remove generated-configure.sh and instead use autoconf

2018-01-18 Thread Erik Joelsson
On 2018-01-18 07:42, Jonathan Gibbons wrote: On 1/18/18 5:28 AM, Magnus Ihse Bursie wrote: * Only a specific version of autoconf, 2.69, can be used, to avoid large code changes in the generated file. Unfortunately, Ubuntu ships a version of autoconf that claims to be 2.69 but is actually h

Re: RFR: JDK-8195689 Remove generated-configure.sh and instead use autoconf

2018-01-18 Thread Jonathan Gibbons
On 1/18/18 8:39 AM, Erik Joelsson wrote: On 2018-01-18 07:42, Jonathan Gibbons wrote: On 1/18/18 5:28 AM, Magnus Ihse Bursie wrote: * Only a specific version of autoconf, 2.69, can be used, to avoid large code changes in the generated file. Unfortunately, Ubuntu ships a version of autoc

Re: RFR: JDK-8195689 Remove generated-configure.sh and instead use autoconf

2018-01-18 Thread Erik Joelsson
Hello Magnus, Nice to see this finally happening! In building.md, when getting autoconf for Cygwin, I believe you also need the autoconf wrapper scripts package. Perhaps it's also worth mentioning that you can download the autoconf src and build/install from there? In jib-profiles.js, you n

Re: RFR: JDK-8195689 Remove generated-configure.sh and instead use autoconf

2018-01-18 Thread David Holmes
On 18/01/2018 11:28 PM, Magnus Ihse Bursie wrote: Currently, we require all developers who modify the configure script to run autoconf locally, to update the generated-configure.sh script, which is then checked in. This is the only instance of checked in "compiled" code in OpenJDK, and this has

Re: RFR: JDK-8195689 Remove generated-configure.sh and instead use autoconf

2018-01-18 Thread Erik Joelsson
Just apply the patch and you can try it. The current version of the patch is somewhat broken on windows though, needs another iteration. /Erik ⁣Sent from BlueMail ​ On Jan 18, 2018, 18:14, at 18:14, David Holmes wrote: >On 18/01/2018 11:28 PM, Magnus Ihse Bursie wrote: >> Currently, we require

Re: RFR: JDK-8195689 Remove generated-configure.sh and instead use autoconf

2018-01-18 Thread Martin Buchholz
Differing projects have come to different conclusions about whether to include a generated configure. But the standard seems to be to include one. The mantra is: "./configure && make" without an autoconf step. The number of people building openjdk is much larger than the number of people patching

Re: RFR: JDK-8195689 Remove generated-configure.sh and instead use autoconf

2018-01-18 Thread Martin Buchholz
Another possibility is implementing the invariant that configure is generated via autoconf 2.69 by a mercurial commit hook. On Thu, Jan 18, 2018 at 10:18 PM, Martin Buchholz wrote: > Differing projects have come to different conclusions about whether to > include a generated configure. > > But t

Re: RFR: JDK-8195689 Remove generated-configure.sh and instead use autoconf

2018-01-18 Thread Erik Helin
On 01/19/2018 07:18 AM, Martin Buchholz wrote: Differing projects have come to different conclusions about whether to include a generated configure. But the standard seems to be to include one. The mantra is: "./configure && make" without an autoconf step. And this is still the mantra (except

Re: RFR: JDK-8195689 Remove generated-configure.sh and instead use autoconf

2018-01-18 Thread Magnus Ihse Bursie
On 2018-01-19 07:18, Martin Buchholz wrote: Differing projects have come to different conclusions about whether to include a generated configure. But the standard seems to be to include one. The mantra is: "./configure && make" without an autoconf step. The number of people building openjdk i

Re: RFR: JDK-8195689 Remove generated-configure.sh and instead use autoconf

2018-01-18 Thread Magnus Ihse Bursie
On 2018-01-19 08:08, Erik Helin wrote: On 01/19/2018 07:18 AM, Martin Buchholz wrote: Differing projects have come to different conclusions about whether to include a generated configure. But the standard seems to be to include one. The mantra is: "./configure && make" without an autoconf ste

Re: RFR: JDK-8195689 Remove generated-configure.sh and instead use autoconf

2018-01-19 Thread Martin Buchholz
Alright folks, you've convinced me. The "builder interface" is the same "bash configure && make" (aside: having configure be non-executable is super-annoying, because it changes an interface burned into my fingers) and yes, users already have to install many dependencies. I was thinking you would

Re: RFR: JDK-8195689 Remove generated-configure.sh and instead use autoconf

2018-01-25 Thread Magnus Ihse Bursie
On 2018-01-18 19:37, Erik Joelsson wrote: Hello Magnus, Nice to see this finally happening! Thanks! In building.md, when getting autoconf for Cygwin, I believe you also need the autoconf wrapper scripts package. Hm, well, no, it's the other way around. "autoconf" is the name of the cygwin

Re: RFR: JDK-8195689 Remove generated-configure.sh and instead use autoconf

2018-02-01 Thread Erik Joelsson
This version looks good to me. /Erik On 2018-01-25 13:33, Magnus Ihse Bursie wrote: On 2018-01-18 19:37, Erik Joelsson wrote: Hello Magnus, Nice to see this finally happening! Thanks! In building.md, when getting autoconf for Cygwin, I believe you also need the autoconf wrapper scripts