Re: [OpenJDK 2D-Dev] RFR: JDK-8198844 Clean up GensrcX11Wrappers

2018-03-05 Thread Phil Race
It isn't "unlikely" .. it is just "relatively rare". -phil. On 03/05/2018 04:00 PM, Magnus Ihse Bursie wrote: On 2018-03-06 00:53, Phil Race wrote: + $(ECHO) needs to be updated for both 32 and 64 bit platforms. You have now needs -> need. Fixed typo. Thanks! (I really hate how I suck at tho

Re: [OpenJDK 2D-Dev] RFR: JDK-8198844 Clean up GensrcX11Wrappers

2018-03-05 Thread Magnus Ihse Bursie
On 2018-03-06 00:53, Phil Race wrote: + $(ECHO) needs to be updated for both 32 and 64 bit platforms. You have now needs -> need. Fixed typo. Thanks! (I really hate how I suck at those English plural s'es :-&) Could we make this easier by trying to generate the 32 bit native binary as well if

Re: [OpenJDK 2D-Dev] RFR: JDK-8198844 Clean up GensrcX11Wrappers

2018-03-05 Thread Phil Race
+ $(ECHO) needs to be updated for both 32 and 64 bit platforms. You have now needs -> need. Could we make this easier by trying to generate the 32 bit native binary as well if running on 64 bits ? Looks like this was not normally done on Linux but if you have 32 bit compiler + library support i

Re: [OpenJDK 2D-Dev] RFR: JDK-8198844 Clean up GensrcX11Wrappers

2018-03-05 Thread Magnus Ihse Bursie
On 2018-03-05 23:38, Phil Race wrote: >I'm not sure what role the "verification" step we had before ever played. >For all the years we've been "verifying" this, we've detected no differences. I think this is useful in the event that you make some changes and regenerate the 64 bit sizes but no

Re: [OpenJDK 2D-Dev] RFR: JDK-8198844 Clean up GensrcX11Wrappers

2018-03-05 Thread Phil Race
>I'm not sure what role the "verification" step we had before ever played. >For all the years we've been "verifying" this, we've detected no differences. I think this is useful in the event that you make some changes and regenerate the 64 bit sizes but not 32 bit. For example this old bug simi

Re: RFR: JDK-8198844 Clean up GensrcX11Wrappers

2018-03-02 Thread Erik Joelsson
Adding 2d-dev in the hopes of getting some input from component team. Seems like they should be aware of us removing the support for multiple data models. Looks like you left a debug message at line 40 in GensrcX11Wrappers.gmk. /Erik On 2018-03-02 03:00, Magnus Ihse Bursie wrote: On 2018-03-

Re: RFR: JDK-8198844 Clean up GensrcX11Wrappers

2018-03-02 Thread Magnus Ihse Bursie
On 2018-03-02 00:02, Erik Joelsson wrote: Hello, In xlibtypes.txt comment, should it be sizes-64.txt? Yes, good catch. Generating both 32 and 64 seems a bit outdated at this point. Surely this is a remnant of bundling 64 and 32 bit together on Solaris in the past? Perhaps someone in 2d ca

Re: RFR: JDK-8198844 Clean up GensrcX11Wrappers

2018-03-01 Thread Erik Joelsson
Hello, In xlibtypes.txt comment, should it be sizes-64.txt? Generating both 32 and 64 seems a bit outdated at this point. Surely this is a remnant of bundling 64 and 32 bit together on Solaris in the past? Perhaps someone in 2d can answer this? Would be nice to be able to clean up that part a

RFR: JDK-8198844 Clean up GensrcX11Wrappers

2018-02-28 Thread Magnus Ihse Bursie
My hunt on technical debt continues. This time my aim has been on the sorry mess known as GensrcX11Wrappers. I've disentangled it into two functions, one simple gensrc part that is actually run during the build, and which involves just a simple java tool and some pre-calculated data files, and