Re: RFR: JDK-8201483 Make it possible to disable JVM features

2018-04-13 Thread David Holmes
On 13/04/2018 5:40 PM, Magnus Ihse Bursie wrote: On 2018-04-12 23:30, David Holmes wrote: On 12/04/2018 11:33 PM, Magnus Ihse Bursie wrote: On 2018-04-12 14:15, David Holmes wrote: Hi Magnus, On 12/04/2018 9:39 PM, Magnus Ihse Bursie wrote: It is currently easy to add new JVM features to th

Re: RFR: JDK-8201483 Make it possible to disable JVM features

2018-04-13 Thread David Holmes
On 13/04/2018 5:25 PM, Volker Simonis wrote: On Thu, Apr 12, 2018 at 11:30 PM, David Holmes wrote: On 12/04/2018 11:33 PM, Magnus Ihse Bursie wrote: On 2018-04-12 14:15, David Holmes wrote: Hi Magnus, On 12/04/2018 9:39 PM, Magnus Ihse Bursie wrote: It is currently easy to add new JVM

Re: RFR: JDK-8201483 Make it possible to disable JVM features

2018-04-13 Thread Magnus Ihse Bursie
On 2018-04-12 23:30, David Holmes wrote: On 12/04/2018 11:33 PM, Magnus Ihse Bursie wrote: On 2018-04-12 14:15, David Holmes wrote: Hi Magnus, On 12/04/2018 9:39 PM, Magnus Ihse Bursie wrote: It is currently easy to add new JVM features to the JVM build, but it is not possible to remove featu

Re: RFR: JDK-8201483 Make it possible to disable JVM features

2018-04-13 Thread Volker Simonis
On Thu, Apr 12, 2018 at 11:30 PM, David Holmes wrote: > On 12/04/2018 11:33 PM, Magnus Ihse Bursie wrote: >> >> On 2018-04-12 14:15, David Holmes wrote: >>> >>> Hi Magnus, >>> >>> On 12/04/2018 9:39 PM, Magnus Ihse Bursie wrote: It is currently easy to add new JVM features to the JVM bui

Re: RFR: JDK-8201483 Make it possible to disable JVM features

2018-04-12 Thread David Holmes
On 12/04/2018 11:33 PM, Magnus Ihse Bursie wrote: On 2018-04-12 14:15, David Holmes wrote: Hi Magnus, On 12/04/2018 9:39 PM, Magnus Ihse Bursie wrote: It is currently easy to add new JVM features to the JVM build, but it is not possible to remove features. With this change, features can be b

Re: RFR: JDK-8201483 Make it possible to disable JVM features

2018-04-12 Thread Erik Joelsson
On 2018-04-12 09:53, Magnus Ihse Bursie wrote: 12 apr. 2018 kl. 17:38 skrev Erik Joelsson : Looks good. Especially adding those # header lines in basics.m4! Thanks! I'm actually thinking about splitting out a utils.m4 from basics.m4, for these kinds of helper functions. Sounds ok? Yes, mak

Re: RFR: JDK-8201483 Make it possible to disable JVM features

2018-04-12 Thread Magnus Ihse Bursie
> 12 apr. 2018 kl. 17:38 skrev Erik Joelsson : > > Looks good. Especially adding those # header lines in basics.m4! Thanks! I'm actually thinking about splitting out a utils.m4 from basics.m4, for these kinds of helper functions. Sounds ok? > > I guess a future followup now is to get rid of

Re: RFR: JDK-8201483 Make it possible to disable JVM features

2018-04-12 Thread Erik Joelsson
Looks good. Especially adding those # header lines in basics.m4! I guess a future followup now is to get rid of the individual enable/disable args that are now redundant. /Erik On 2018-04-12 04:39, Magnus Ihse Bursie wrote: It is currently easy to add new JVM features to the JVM build, but i

Re: RFR: JDK-8201483 Make it possible to disable JVM features

2018-04-12 Thread Thomas Stüfe
On Thu, Apr 12, 2018 at 3:38 PM, Magnus Ihse Bursie wrote: > On 2018-04-12 14:11, Thomas Stüfe wrote: >> >> Hi Magnus, >> >> this is nice. I would like a clearer naming though, that single dash >> is easily overlooked. How about --without-jvm-features instead? > > > This is not possible. --without

Re: RFR: JDK-8201483 Make it possible to disable JVM features

2018-04-12 Thread Magnus Ihse Bursie
On 2018-04-12 14:11, Thomas Stüfe wrote: Hi Magnus, this is nice. I would like a clearer naming though, that single dash is easily overlooked. How about --without-jvm-features instead? This is not possible. --without-X is internally replaced by autoconf to "--with-X=no". "--without-X=foo" is

Re: RFR: JDK-8201483 Make it possible to disable JVM features

2018-04-12 Thread Magnus Ihse Bursie
On 2018-04-12 14:15, David Holmes wrote: Hi Magnus, On 12/04/2018 9:39 PM, Magnus Ihse Bursie wrote: It is currently easy to add new JVM features to the JVM build, but it is not possible to remove features. With this change, features can be both added or removed from the default set. They ar

Re: RFR: JDK-8201483 Make it possible to disable JVM features

2018-04-12 Thread David Holmes
Hi Magnus, On 12/04/2018 9:39 PM, Magnus Ihse Bursie wrote: It is currently easy to add new JVM features to the JVM build, but it is not possible to remove features. With this change, features can be both added or removed from the default set. They are added using --with-jvm-features=f1,f2 an

Re: RFR: JDK-8201483 Make it possible to disable JVM features

2018-04-12 Thread Thomas Stüfe
Hi Magnus, this is nice. I would like a clearer naming though, that single dash is easily overlooked. How about --without-jvm-features instead? ..Thomas On Thu, Apr 12, 2018 at 1:39 PM, Magnus Ihse Bursie wrote: > It is currently easy to add new JVM features to the JVM build, but it is not > po

RFR: JDK-8201483 Make it possible to disable JVM features

2018-04-12 Thread Magnus Ihse Bursie
It is currently easy to add new JVM features to the JVM build, but it is not possible to remove features. With this change, features can be both added or removed from the default set. They are added using --with-jvm-features=f1,f2 and removed using --with-jvm-features=-f1,-f2. The syntax can b