Re: RFR: JDK-8202200: set INCLUDE_SA to false on s390x by default -was : RE: INCLUDE_SA/serviceability agent - support on s390x

On 2018-04-25 10:14, Baesken, Matthias wrote: Hi Erik, thanks ! Can I consider this as a review ? In the meantime I created a webrev + bug : webrev for review  : http://cr.openjdk.java.net/~mbaesken/webrevs/8202200/ Looks good to

RE: RFR: JDK-8202200: set INCLUDE_SA to false on s390x by default -was : RE: INCLUDE_SA/serviceability agent - support on s390x

Hi Erik, thanks ! Can I consider this as a review ? In the meantime I created a webrev + bug : webrev for review : http://cr.openjdk.java.net/~mbaesken/webrevs/8202200/ bug : https://bugs.openjdk.java.net/browse/JDK-8202200 Regards, Matthias From: Erik Joelsson [mailto:erik.joels...

Re: RFR: JDK-8202200: set INCLUDE_SA to false on s390x by default -was : RE: INCLUDE_SA/serviceability agent - support on s390x

Looks good to me, Matthias. Thank you, Jini. On 4/24/2018 9:39 PM, Baesken, Matthias wrote: Hi Jini, the removal of the mentioned headers leads to build errors so we better keep it . Error is when the headers are removed : /nb/linuxs390x/nightly/jdk/src/hotspot/share/runtime/vmStructs.cp

RFR: JDK-8202200: set INCLUDE_SA to false on s390x by default -was : RE: INCLUDE_SA/serviceability agent - support on s390x

Hi Jini, the removal of the mentioned headers leads to build errors so we better keep it . Error is when the headers are removed : /nb/linuxs390x/nightly/jdk/src/hotspot/share/runtime/vmStructs.cpp:100:31: fatal error: vmStructs_s390.hpp: No such file or directory #include CPU_HEADER(vmStr