The makefile changes look good to me!
Cheers,
Mikael
> On Jun 16, 2020, at 12:22 PM, Erik Joelsson wrote:
>
> (re-sending this as it doesn't look like it was delivered)
>
> There are a lot of jtreg tests that use temporary files. These temporary
> files add up over time and fill up the glob
On 6/17/20 6:11 am, Erik Joelsson wrote:
On 2020-06-16 23:25, Sergey Bylokhov wrote:
As far as I understand this new temp folder will be cleaned after every
tests run, doesn't it look like a workaround for problematic tests and
product bugs?
This new tmp folder is created in the jtreg test-supp
On 17/06/2020 16:38, Erik Joelsson wrote:
Ah, misunderstood you then. I added a comment to JDK-8213216 with more
details and shortened the comment in the test:
http://cr.openjdk.java.net/~erikj/8213214/webrev.03/
Looks okay as a workaround until we figure out what to do with subst.
-Alan.
On 6/17/20 5:55 AM, Erik Joelsson wrote:
On 2020-06-16 15:53, Jonathan Gibbons wrote:
It would also be good to identify the tests that are using temporary
directories in this manner and have them use the jtreg scratch
directory where possible.
I completely agree that tests should be fixed t
On 2020-06-17 07:43, Alan Bateman wrote:
On 17/06/2020 14:47, Erik Joelsson wrote:
I've tried to make this clearer in the comment.
http://cr.openjdk.java.net/~erikj/8213214/webrev.02/
I would prefer if you could move the notes/comment from L125-157 to
the bug report to avoid cluttering the
On 17/06/2020 14:47, Erik Joelsson wrote:
I've tried to make this clearer in the comment.
http://cr.openjdk.java.net/~erikj/8213214/webrev.02/
I would prefer if you could move the notes/comment from L125-157 to the
bug report to avoid cluttering the test. Instead, the test just needs a
one l
On 2020-06-17 01:24, Alan Bateman wrote:
On 16/06/2020 18:44, Erik Joelsson wrote:
There are a lot of jtreg tests that use temporary files. These
temporary files add up over time and fill up the global temp
directories on our test systems. To tackle this, we should try to
redirect these temp
On 2020-06-16 23:25, Sergey Bylokhov wrote:
As far as I understand this new temp folder will be cleaned after every
tests run, doesn't it look like a workaround for problematic tests and
product bugs?
This new tmp folder is created in the jtreg test-support dir (which is
where we direct the jtre
On 2020-06-16 15:53, Jonathan Gibbons wrote:
It would also be good to identify the tests that are using temporary
directories in this manner and have them use the jtreg scratch
directory where possible.
I completely agree that tests should be fixed to behave better. Using
scratch instead of t
On 16/06/2020 18:44, Erik Joelsson wrote:
There are a lot of jtreg tests that use temporary files. These
temporary files add up over time and fill up the global temp
directories on our test systems. To tackle this, we should try to
redirect these temporary files into a directory controlled by t
As far as I understand this new temp folder will be cleaned after every
tests run, doesn't it look like a workaround for problematic tests and
product bugs?
Personally, I found many bugs in the tests and some product bugs as
well, which caused "leakage" of the temporary files.
Probably additional
It would also be good to identify the tests that are using temporary
directories in this manner and have them use the jtreg scratch directory
where possible.
-- Jon
On 6/16/20 12:22 PM, Erik Joelsson wrote:
(re-sending this as it doesn't look like it was delivered)
There are a lot of jtreg t
(re-sending this as it doesn't look like it was delivered)
There are a lot of jtreg tests that use temporary files. These temporary
files add up over time and fill up the global temp directories on our
test systems. To tackle this, we should try to redirect these temporary
files into a directo
There are a lot of jtreg tests that use temporary files. These temporary
files add up over time and fill up the global temp directories on our
test systems. To tackle this, we should try to redirect these temporary
files into a directory controlled by the test framework. Jtreg does not
do this,
14 matches
Mail list logo
