Thanks for the review, Alan and Magnus.
Cheers,
Henry
> On Nov 30, 2018, at 7:20 AM, Alan Bateman wrote:
>
>
>
> On 28/11/2018 22:49, Henry Jen wrote:
>> Since there is no header file in JDK provides the function prototypes, I
>> don’t think this is considered public(supported) APIs.
>>
>>
On 28/11/2018 22:49, Henry Jen wrote:
Since there is no header file in JDK provides the function prototypes, I don’t
think this is considered public(supported) APIs.
Anyway, in case a tools is build with launcher code, and shipped separately
from JDK, that would be impacted by this bug. So
On 2018-11-28 23:49, Henry Jen wrote:
Since there is no header file in JDK provides the function prototypes, I don’t
think this is considered public(supported) APIs.
Anyway, in case a tools is build with launcher code, and shipped separately
from JDK, that would be impacted by this bug. So I
Since there is no header file in JDK provides the function prototypes, I don’t
think this is considered public(supported) APIs.
Anyway, in case a tools is build with launcher code, and shipped separately
from JDK, that would be impacted by this bug. So I added a test call JLI_Launch
as well. Pl
> On Nov 28, 2018, at 12:46 AM, Alan Bateman wrote:
>
> On 27/11/2018 23:05, Henry Jen wrote:
>> Hi,
>>
>> Please review a follow up webrev[1] based on Priyanka’s patch, it simply
>> added a test case for Mac only that will link with libjli.
>> Note that, to use invoke API, one should probab
On 11/28/2018 5:19 AM, Alan Bateman wrote:
On 28/11/2018 13:13, Kevin Rushforth wrote:
The jpackage tool calls JLI_Launch.
I remember that from Andy's webrev but it's not integrated yet. Does
the JavaFX packager tool do the same?
Yes, the javapackager tool (delivered via JavaFX) in JDK 8/9
On 28/11/2018 13:13, Kevin Rushforth wrote:
The jpackage tool calls JLI_Launch.
I remember that from Andy's webrev but it's not integrated yet. Does the
JavaFX packager tool do the same?
-Alan
The jpackage tool calls JLI_Launch.
-- Kevin
On 11/28/2018 5:05 AM, Alan Bateman wrote:
On 28/11/2018 13:03, Kevin Rushforth wrote:
This is related to a bug I filed back in October, JDK-8211959 [1], in
which JLI_Launch is failing for the same reason. The fix to
java_md_macosx.m is the same o
On 28/11/2018 13:03, Kevin Rushforth wrote:
This is related to a bug I filed back in October, JDK-8211959 [1], in
which JLI_Launch is failing for the same reason. The fix to
java_md_macosx.m is the same one I identified in that bug. You might
consider adding a test that calls JLI_Launch, but ei
This is related to a bug I filed back in October, JDK-8211959 [1], in
which JLI_Launch is failing for the same reason. The fix to
java_md_macosx.m is the same one I identified in that bug. You might
consider adding a test that calls JLI_Launch, but either way,
JDK-8211959 can be closed as a dup
On 27/11/2018 23:05, Henry Jen wrote:
Hi,
Please review a follow up webrev[1] based on Priyanka’s patch, it simply added
a test case for Mac only that will link with libjli.
Note that, to use invoke API, one should probably link with libjvm, which works
for all supported platforms, not just Ma
Hi,
Please review a follow up webrev[1] based on Priyanka’s patch, it simply added
a test case for Mac only that will link with libjli.
Note that, to use invoke API, one should probably link with libjvm, which works
for all supported platforms, not just Mac.
Cheers,
Henry
[1] http://cr.openjdk
12 matches
Mail list logo
