Re: RFR: JDK-8216489: Issues with ModulePackages attribute generation on incremental build

2019-01-10 Thread Tim Bell
Erik: Looks good. I agree with Alan - that is a very subtle typo. Tim On 01/10/19 09:23, Alan Bateman wrote: On 10/01/2019 17:14, Erik Joelsson wrote: The incremental build of exploded-image-optimize is broken. This is caused by a small typo in the prerequisites declaration for the recipe.

Re: RFR: JDK-8216489: Issues with ModulePackages attribute generation on incremental build

2019-01-10 Thread Alan Bateman
On 10/01/2019 17:14, Erik Joelsson wrote: The incremental build of exploded-image-optimize is broken. This is caused by a small typo in the prerequisites declaration for the recipe. Bug: https://bugs.openjdk.java.net/browse/JDK-8216489 Webrev: http://cr.openjdk.java.net/~erikj/8216489/webrev.0

RFR: JDK-8216489: Issues with ModulePackages attribute generation on incremental build

2019-01-10 Thread Erik Joelsson
The incremental build of exploded-image-optimize is broken. This is caused by a small typo in the prerequisites declaration for the recipe. Bug: https://bugs.openjdk.java.net/browse/JDK-8216489 Webrev: http://cr.openjdk.java.net/~erikj/8216489/webrev.01/ /Erik

Re: RFR: JDK-8216489: Issues with ModulePackages attribute generation on incremental build

2019-01-10 Thread Claes Redestad
Looks good! /Claes Erik Joelsson skrev: (10 januari 2019 18:14:51 CET) >The incremental build of exploded-image-optimize is broken. This is >caused by a small typo in the prerequisites declaration for the recipe. > >Bug: https://bugs.openjdk.java.net/browse/JDK-8216489 > >Webrev: http://cr.open