Re: RFR: JDK-8223319: Add copyright footer to specs and man pages

2019-05-03 Thread serguei . spitsyn
On 5/3/19 2:00 PM, Erik Joelsson wrote: I posted the diff for jdwp-protocol.html below too (but I forgot the dot in the filename). That file currently does not have any copyright visible in html, but the new footer looks the same (except for having a different relative path in the link to co

Re: RFR: JDK-8223319: Add copyright footer to specs and man pages

2019-05-03 Thread Erik Joelsson
I posted the diff for jdwp-protocol.html below too (but I forgot the dot in the filename). That file currently does not have any copyright visible in html, but the new footer looks the same (except for having a different relative path in the link to copyright.html). /Erik On 2019-05-03 13:35,

Re: RFR: JDK-8223319: Add copyright footer to specs and man pages

2019-05-03 Thread serguei . spitsyn
Thank you, Erik. Is it the same with the jdwp-protocol.html? If so then I'm Okay with the fix. Thanks, Serguei On 5/3/19 11:50 AM, Erik Joelsson wrote: The new footer looks exactly like on the api docs today. jvmti.html: 36481,36484c36481 < < Copyright (c) 2002, 2018, Oracle and

RE: RFR: JDK-8223319: Add copyright footer to specs and man pages

2019-05-03 Thread Iris Clark
Hi, Erik. > New webrev: http://cr.openjdk.java.net/~erikj/8223319/webrev.02/ The revised webrev looks good. Thank you! Iris

Re: RFR: JDK-8223319: Add copyright footer to specs and man pages

2019-05-03 Thread Erik Joelsson
The new footer looks exactly like on the api docs today. jvmti.html: 36481,36484c36481 < < Copyright (c) 2002, 2018, Oracle and/or its affiliates. All rights reserved. <   < --- > Copyright © 1993, 2019, Oracle and/or its affiliates, 500 Oracle Parkway, Redwood Shores,

Re: RFR: JDK-8223319: Add copyright footer to specs and man pages

2019-05-03 Thread [email protected]
Hi Erik, Could you, please, show a simple diff for jvmti.html and jdwp-protocol.html? Thanks, Serguei On 5/3/19 09:37, Erik Joelsson wrote: The (optional) specs and man pages should have the same copyright footer as the generated API docs. This patch adds the logic to add such footers. It al

Re: RFR: JDK-8223319: Add copyright footer to specs and man pages

2019-05-03 Thread Erik Joelsson
Sent: Friday, May 3, 2019 9:38 AM To: build-dev ; OpenJDK Serviceability Subject: RFR: JDK-8223319: Add copyright footer to specs and man pages The (optional) specs and man pages should have the same copyright footer as the generated API docs. This patch adds the logic to add such footers. It

RE: RFR: JDK-8223319: Add copyright footer to specs and man pages

2019-05-03 Thread Iris Clark
a.net/jdk/jdk/rev/9884b717f2ed Thanks, iris -Original Message- From: Erik Joelsson Sent: Friday, May 3, 2019 9:38 AM To: build-dev ; OpenJDK Serviceability Subject: RFR: JDK-8223319: Add copyright footer to specs and man pages The (optional) specs and man pages should have the same copy

RFR: JDK-8223319: Add copyright footer to specs and man pages

2019-05-03 Thread Erik Joelsson
The (optional) specs and man pages should have the same copyright footer as the generated API docs. This patch adds the logic to add such footers. It also removes the existing footer in jvmti.html. Bug: https://bugs.openjdk.java.net/browse/JDK-8223319 Webrev: http://cr.openjdk.java.net/~erikj/