Great. I'll push it tomorrow.
/Christoph
> -Original Message-
> From: Erik Joelsson
> Sent: Donnerstag, 13. Februar 2020 18:18
> To: René Schünemann ; Langer, Christoph
>
> Cc: build-dev@openjdk.java.net
> Subject: Re: RFR: JDK-8238534
>
> Looks good.
Looks good.
/Erik
On 2020-02-13 01:17, René Schünemann wrote:
Hi Erik and Christoph,
thank you for your reviews.
The added touch works for me too. I have adapted the suggested whitespace fixes.
Here is the updated WebRev:
http://cr.openjdk.java.net/~rschuenemann/wr/2020/8238534-macos_sign_bun
Hi Erik and Christoph,
thank you for your reviews.
The added touch works for me too. I have adapted the suggested whitespace fixes.
Here is the updated WebRev:
http://cr.openjdk.java.net/~rschuenemann/wr/2020/8238534-macos_sign_bundles/04/
Rene
On Wed, Feb 12, 2020 at 8:09 PM Erik Joelsson wro
Hello Rene,
On 2020-02-12 02:54, René Schünemann wrote:
Hello Erik,
thank you for your guidance.
I have implemented your requested changes.
Updated WebRev:
http://cr.openjdk.java.net/~rschuenemann/wr/2020/8238534-macos_sign_bundles/03/
Much better. I still have some style issues [1]. The rec
ely shouldn't. I can also sponsor the push eventually.
Best regards
Christoph
> -Original Message-
> From: build-dev On Behalf Of René
> Schünemann
> Sent: Mittwoch, 12. Februar 2020 11:55
> To: Erik Joelsson
> Cc: build-dev@openjdk.java.net
> Subject: Re: RFR: J
Hello Erik,
thank you for your guidance.
I have implemented your requested changes.
Updated WebRev:
http://cr.openjdk.java.net/~rschuenemann/wr/2020/8238534-macos_sign_bundles/03/
There is one thin I notice though. On my machine the bundles are
getting resigned and rebuilt every time I call make
On 2020-02-11 01:08, René Schünemann wrote:
Hello Erik,
thank you for your review. Please see my answers below.
Rene
On Mon, Feb 10, 2020 at 9:34 PM Erik Joelsson wrote:
Hello René,
That looks better. I still have some issues though.
I don't understand line 273 and 305. There is no reason
Hello Erik,
thank you for your review. Please see my answers below.
Rene
On Mon, Feb 10, 2020 at 9:34 PM Erik Joelsson wrote:
>
> Hello René,
>
> That looks better. I still have some issues though.
>
> I don't understand line 273 and 305. There is no reason to declare those
> rules.
>
> Line 31
Hello René,
That looks better. I still have some issues though.
I don't understand line 273 and 305. There is no reason to declare those
rules.
Line 311, the CodeResources file needs prerequisites. Those should be
$(CREATE_JDK_BUNDLE_DIR_SIGNED) (which is the list of all files copied
into t
Hi Erik,
I have implemented your requested changes. I think it is a lot cleaner
now and the bundling as well as the
signing parts are now only executed when necessary.
New WebRev:
http://cr.openjdk.java.net/~rschuenemann/wr/2020/8238534-macos_sign_bundles/02/
Rene
On Mon, Feb 10, 2020 at 9:23
Hi Erik,
thank you for your review and I totally agree with you. It would
definitely be better avoid temp dirs.
I will try to move the creation of the signed image to MacBundles.gmk
and then re-use the SetubBundleFile in Bundles.gmk.
Rene
On Fri, Feb 7, 2020 at 5:19 PM Erik Joelsson wrote:
>
>
Hello René,
It's good to see an open solution to this, but I have some opinions on
the patch.
The concept of building into "temp dirs" that are then removed is a
practice we try to avoid in the build. Whenever possible, each rule
should be a well defined transformation from a set of source f
For the Apple notarization process, the whole bundle in its final form
has to be signed with the codesign tool.
See the discussion here: https://bugs.openjdk.java.net/browse/JDK-8238225
This change copies all JDK/JRE files to a temporary directory, which
is then passed to the codesign tool. The te
13 matches
Mail list logo
