Re: RFR: JDK-8241616: Timestamps on ct.sym entries lead to non-reproducible builds

2020-05-11 Thread Magnus Ihse Bursie
On 2020-05-11 17:25, Jan Lahoda wrote: Thanks Magnus for the SOURCE_DATE_EPOCH! I've adjusted the patch to use it: http://cr.openjdk.java.net/~jlahoda/8241616/webrev.01/ It also explicitly sets the output of TransitiveDependencies on the command line (before it was passing just the directory

Re: RFR: JDK-8241616: Timestamps on ct.sym entries lead to non-reproducible builds

2020-05-11 Thread Martin Buchholz
fyi Build reproducibility has become more important over the years. That is especially true at Google, where reproducible builds are more efficient. We have modified versions of various archivers that can generate deterministic metadata in the archive. And that includes the "jar" command. The file

Re: RFR: JDK-8241616: Timestamps on ct.sym entries lead to non-reproducible builds

2020-05-11 Thread Jan Lahoda
Thanks Magnus for the SOURCE_DATE_EPOCH! I've adjusted the patch to use it: http://cr.openjdk.java.net/~jlahoda/8241616/webrev.01/ It also explicitly sets the output of TransitiveDependencies on the command line (before it was passing just the directory into which the file was written). Also

Re: RFR: JDK-8241616: Timestamps on ct.sym entries lead to non-reproducible builds

2020-05-07 Thread Magnus Ihse Bursie
On 2020-04-30 14:50, Jan Lahoda wrote: On 30. 04. 20 14:29, Magnus Ihse Bursie wrote: On 2020-04-30 12:41, Alan Bateman wrote: On 30/04/2020 08:03, Jan Lahoda wrote: Hi, The building of lib/ct.sym is not reproducible, due to timestamps of files inside the file (which is basically a zip

Re: RFR: JDK-8241616: Timestamps on ct.sym entries lead to non-reproducible builds

2020-04-30 Thread Jan Lahoda
On 30. 04. 20 14:29, Magnus Ihse Bursie wrote: On 2020-04-30 12:41, Alan Bateman wrote: On 30/04/2020 08:03, Jan Lahoda wrote: Hi, The building of lib/ct.sym is not reproducible, due to timestamps of files inside the file (which is basically a zip file). The proposed solution is to use a

Re: RFR: JDK-8241616: Timestamps on ct.sym entries lead to non-reproducible builds

2020-04-30 Thread Magnus Ihse Bursie
On 2020-04-30 10:21, Jan Lahoda wrote: On 30. 04. 20 9:49, Magnus Ihse Bursie wrote: On 2020-04-30 09:03, Jan Lahoda wrote: Hi, The building of lib/ct.sym is not reproducible, due to timestamps of files inside the file (which is basically a zip file). The proposed solution is to use a

Re: RFR: JDK-8241616: Timestamps on ct.sym entries lead to non-reproducible builds

2020-04-30 Thread Magnus Ihse Bursie
On 2020-04-30 12:41, Alan Bateman wrote: On 30/04/2020 08:03, Jan Lahoda wrote: Hi, The building of lib/ct.sym is not reproducible, due to timestamps of files inside the file (which is basically a zip file). The proposed solution is to use a constant timestamp for the files inside the

Re: RFR: JDK-8241616: Timestamps on ct.sym entries lead to non-reproducible builds

2020-04-30 Thread Alan Bateman
On 30/04/2020 08:03, Jan Lahoda wrote: Hi, The building of lib/ct.sym is not reproducible, due to timestamps of files inside the file (which is basically a zip file). The proposed solution is to use a constant timestamp for the files inside the ct.sym file. To simplify the construction,

Re: RFR: JDK-8241616: Timestamps on ct.sym entries lead to non-reproducible builds

2020-04-30 Thread Jan Lahoda
On 30. 04. 20 9:49, Magnus Ihse Bursie wrote: On 2020-04-30 09:03, Jan Lahoda wrote: Hi, The building of lib/ct.sym is not reproducible, due to timestamps of files inside the file (which is basically a zip file). The proposed solution is to use a constant timestamp for the files inside the

Re: RFR: JDK-8241616: Timestamps on ct.sym entries lead to non-reproducible builds

2020-04-30 Thread Magnus Ihse Bursie
On 2020-04-30 09:03, Jan Lahoda wrote: Hi, The building of lib/ct.sym is not reproducible, due to timestamps of files inside the file (which is basically a zip file). The proposed solution is to use a constant timestamp for the files inside the ct.sym file. To simplify the construction, the

RFR: JDK-8241616: Timestamps on ct.sym entries lead to non-reproducible builds

2020-04-30 Thread Jan Lahoda
Hi, The building of lib/ct.sym is not reproducible, due to timestamps of files inside the file (which is basically a zip file). The proposed solution is to use a constant timestamp for the files inside the ct.sym file. To simplify the construction, the CreateSymbols tool does not produce