Looks good to me.
/Erik
On 2020-04-29 03:47, Alan Bateman wrote:
On 29/04/2020 11:40, Magnus Ihse Bursie wrote:
:
http://cr.openjdk.java.net/~ihse/JDK-8243665-fix-AddPackagesAttribute/webrev.02
Looks good. It could be optimized to only read the module-info.class
once but will hardly be
On 2020-04-29 12:47, Alan Bateman wrote:
On 29/04/2020 11:40, Magnus Ihse Bursie wrote:
:
http://cr.openjdk.java.net/~ihse/JDK-8243665-fix-AddPackagesAttribute/webrev.02
Looks good.
Thanks.
It could be optimized to only read the module-info.class once but will
hardly be noticeable I
On 29/04/2020 11:40, Magnus Ihse Bursie wrote:
:
http://cr.openjdk.java.net/~ihse/JDK-8243665-fix-AddPackagesAttribute/webrev.02
Looks good. It could be optimized to only read the module-info.class
once but will hardly be noticeable I suspect.
-Alan
On 2020-04-29 12:31, Alan Bateman wrote:
On 29/04/2020 10:27, Magnus Ihse Bursie wrote:
Due to the current design of the AddPackagesAttribute build tool, all
module-info.class files will be written to, when the tool is run.
This happens whenever at least one module-info.class file has been
On 29/04/2020 10:27, Magnus Ihse Bursie wrote:
Due to the current design of the AddPackagesAttribute build tool, all
module-info.class files will be written to, when the tool is run. This
happens whenever at least one module-info.class file has been updated.
The end result of this is that
Due to the current design of the AddPackagesAttribute build tool, all
module-info.class files will be written to, when the tool is run. This
happens whenever at least one module-info.class file has been updated.
The end result of this is that if you recompile a single module, *all*
modules
