On 2020-05-18 22:55, Lemmond, Dan wrote:
Hi,
Please find the updated review here:
http://cr.openjdk.java.net/~phh/8244966/webrev.02/
I have added the .vscode directory to the .gitignore as well, keeping both the
.hgignore and .gitignore in sync.
Testing was re-conducted and I verified that t
Looks good.
/Erik
On 2020-05-18 13:55, Lemmond, Dan wrote:
Hi,
Please find the updated review here:
http://cr.openjdk.java.net/~phh/8244966/webrev.02/
I have added the .vscode directory to the .gitignore as well, keeping both the
.hgignore and .gitignore in sync.
Testing was re-conducted a
Hi,
Please find the updated review here:
http://cr.openjdk.java.net/~phh/8244966/webrev.02/
I have added the .vscode directory to the .gitignore as well, keeping both the
.hgignore and .gitignore in sync.
Testing was re-conducted and I verified that the .vscode directory is still
ignored. Ple
On 2020-05-16 01:06, Lemmond, Dan wrote:
Hi,
This is my first review request so apologies for any missteps or
inconsistencies.
JBS: https://bugs.openjdk.java.net/browse/JDK-8244966
Webrev: http://cr.openjdk.java.net/~phh/8244966/webrev.01/
Please review this change that adds the .vscode direc
LGTM.
Cheers, Thomas
On Sat, May 16, 2020 at 1:34 AM Lemmond, Dan wrote:
> Hi,
>
> This is my first review request so apologies for any missteps or
> inconsistencies.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8244966
> Webrev: http://cr.openjdk.java.net/~phh/8244966/webrev.01/
>
> Pleas
Hi,
This is my first review request so apologies for any missteps or
inconsistencies.
JBS: https://bugs.openjdk.java.net/browse/JDK-8244966
Webrev: http://cr.openjdk.java.net/~phh/8244966/webrev.01/
Please review this change that adds the .vscode directory to .hgignore, similar
to the .idea di