Hi,
`bin/idea.sh` is not generating the right source folders for
jdk.internal.vm.ci and jdk.internal.vm.compiler modules.
These modules have different directory structures to the rest and so should
be handled exceptionally so that the IDE has the right source folder
definitions.
The fix takes th
The basic fix looks good, I'm wondering, however, if we would only want
to enable sources which match the current configuration? E.g. not add
the sources for aarch64 if building on linux? But if we build all these
modules regardless, then it's ok to add them all.
Maurizio
On 06/08/2020 15:28,
Hi,
On Thu, 2020-08-06 at 16:01 +0100, Maurizio Cimadamore wrote:
> The basic fix looks good, I'm wondering, however, if we would only want
> to enable sources which match the current configuration? E.g. not add
> the sources for aarch64 if building on linux? But if we build all these
> modules
On 06/08/2020 16:35, Severin Gehwolf wrote:
> On Thu, 2020-08-06 at 16:01 +0100, Maurizio Cimadamore wrote:
>> The basic fix looks good, I'm wondering, however, if we would only want
>> to enable sources which match the current configuration? E.g. not add
>> the sources for aarch64 if building on
Sorry for the delay,
overall this looks like a good improvement, so I'll approve.
Is there some colleague that can help you do the push?
Let me know if you need help.
Thanks
Maurizio
On 06/08/2020 15:28, Galder Zamarreno wrote:
Hi,
`bin/idea.sh` is not generating the right source folders for
Hi,
On Thu, 2020-09-03 at 16:48 +0100, Maurizio Cimadamore wrote:
> Sorry for the delay,
> overall this looks like a good improvement, so I'll approve.
>
> Is there some colleague that can help you do the push?
>
> Let me know if you need help.
I'll sponsor the patch for Galder. Yet, sponsoring
I've approved - seems to me that you can now just integrate.
(otherwise, I could have just typed "/sponsor" if the author did not
have commit rights)
Maurizio
On 07/09/2020 17:00, Severin Gehwolf wrote:
Hi,
On Thu, 2020-09-03 at 16:48 +0100, Maurizio Cimadamore wrote:
Sorry for the delay,
