Re: RFR: JDK-8251533 MacOS build of libjimage explicitly adds C++ standard library

2020-08-13 Thread Erik Joelsson
Looks good. In the ADLC case, it seemed to be needed when linking with gcc instead of clang. /Erik On 2020-08-13 05:00, Magnus Ihse Bursie wrote: From the bug report: In CoreLibraries.gmk we have $(eval $(call SetupJdkLibrary, BUILD_LIBJIMAGE, \ ... ???LIBS_unix := -ljvm -ldl $(LIBCXX), \

RFR: JDK-8251533 MacOS build of libjimage explicitly adds C++ standard library

2020-08-13 Thread Magnus Ihse Bursie
From the bug report: In CoreLibraries.gmk we have $(eval $(call SetupJdkLibrary, BUILD_LIBJIMAGE, \ ... ???LIBS_unix := -ljvm -ldl $(LIBCXX), \ ???LIBS_macosx := -lc++, \ I think the LIBS_macosx line should not be needed. Other similar places don't seem to do that. If it were necessary to expl