s, so I would prefer if we can avoid
> doing this.
>
> Thanks
> Markus
>
> -Original Message-
> From: Roman Kennke
> Sent: den 23 juli 2020 22:29
> To: Erik Gahlin
> Cc: hotspot-jfr-...@openjdk.java.net; build-dev <
> build-dev@openjdk.java.net>
&g
connotations, so I would prefer if we can avoid doing this.
Thanks
Markus
-Original Message-
From: Roman Kennke
Sent: den 23 juli 2020 22:29
To: Erik Gahlin
Cc: hotspot-jfr-...@openjdk.java.net; build-dev
Subject: Re: RFR (16): JFR: Separate metadata per JVM-feature
Hi Erik,
> Hi Ro
Thanks, Erik. I can do those changes. But can we first agree with Erik
Gahlin if we want this change at all?
Thanks,
Roman
On Thu, 2020-07-23 at 17:23 -0700, Erik Joelsson wrote:
> Build changes look ok to me. I would prefer if the long "COMMAND"
> line
> was broken up though as the side by side
Build changes look ok to me. I would prefer if the long "COMMAND" line
was broken up though as the side by side diff is already forcing a side
scroll on my smaller monitor.
/Erik
On 2020-07-23 10:48, Roman Kennke wrote:
This is a fall-out from my Shenandoah upstreaming work in JDK11, where
I
Thanks for the explanation.
I think it would better to keep things as is going forward.
Erik
> On 23 Jul 2020, at 22:29, Roman Kennke wrote:
>
> Hi Erik,
>
>
>> Hi Roman,
>>
>> What is the problem you are trying to solve?
>>
>
> It is mostly an exercise in cleanliness. In the effort to u
Hi Erik,
> Hi Roman,
>
> What is the problem you are trying to solve?
>
It is mostly an exercise in cleanliness. In the effort to upstream
Shenandoah GC to jdk11u (which is still ongoing), it has been asked to
make sure that build with Shenandoah excluded (--with-jvm-features=-
shenandoahgc)
Hi Roman,
What is the problem you are trying to solve?
Speed up compilation, or exclude metadata from recordings?
Having metadata per JVM-features adds complexity with little added benefit from
what I can see.
Thanks
Erik
> On 23 Jul 2020, at 19:48, Roman Kennke wrote:
>
> This is a fall-
This is a fall-out from my Shenandoah upstreaming work in JDK11, where
I made a similar change in order to separate-out Shenandoah parts from
JFR build when Shenandoah is disabled.
Currently, all JFR metadata is collected in a single metadata.xml file.
>From those, the build machinery generates he
