Re: RFR (L) 8220747: Migrate data structures to being more C++

2019-05-01 Thread David Holmes
Hi Jc, I just a had a quick look at this so not a full review - sorry. I'm not sure it makes sense to define classes within "extern C {". The extern C is intended to define an interface for this C++ library to be used from a C program - as discussed here for your Solaris issue:

RFR (L) 8220747: Migrate data structures to being more C++

2019-05-01 Thread Jean Christophe Beyler
Hi all, Re-sending with the full title (OK... so JC will promise to go around the block 3 times before submitting a review request; and will do any item you would like to redeem myself; I apologize profusely and feel horrible...) I want to move the libHeapMonitorTest.c to C++ and here is

RFR (L) 8220747:

2019-05-01 Thread Jean Christophe Beyler
Hi all, I want to move the libHeapMonitorTest.c to C++ and here is the first "step" towards that. There are two parts to this: move the file to C++ and move some of the C-style to C++-style code. But this webrev failed on solaris; Igor helped me figure it out and his solution was to add the