I am not an official open source code reviewer, but I did review the code and
it looks good.
Ron
From: Lois Foltan
Sent: Thursday, September 19, 2013 9:11 AM
To: hotspot-runtime-...@openjdk.java.net; build-dev@openjdk.java.net
Subject: RFR (L) JDK-7195622: CheckUnhandledOops has limited
@openjdk.java.net
*Subject:* RFR (L) JDK-7195622: CheckUnhandledOops has limited
usefulness now
Please review the following fix:
Webrev:
http://cr.openjdk.java.net/~hseigel/bug_jdk7195622.0/
http://cr.openjdk.java.net/%7Ehseigel/bug_jdk7195622.0/
Bug: JDK8 b44 hotspot:src/share/vm/oops
Thank you Magnus for reviewing the build piece.
Lois
On 9/20/2013 2:59 AM, Magnus Ihse Bursie wrote:
On 2013-09-19 16:37, Lois Foltan wrote:
Please review the following fix:
Webrev:
http://cr.openjdk.java.net/~hseigel/bug_jdk7195622.0/
The build changes part of the fix looks
On 2013-09-19 16:37, Lois Foltan wrote:
Please review the following fix:
Webrev:
http://cr.openjdk.java.net/~hseigel/bug_jdk7195622.0/
The build changes part of the fix looks unproblematic. (I have not
looked at the rest.)
/Magnus
On 9/19/2013 9:34 PM, Christian Thalinger wrote:
On Sep 19, 2013, at 6:06 PM, Lois Foltan lois.fol...@oracle.com
mailto:lois.fol...@oracle.com wrote:
On 9/19/2013 7:25 PM, Christian Thalinger wrote:
On Sep 19, 2013, at 4:22 PM, Lois Foltanlois.fol...@oracle.com wrote:
On 9/19/2013
On 09/19/2013 05:13 PM, Lois Foltan wrote:
Please review the following fix:
Webrev:
http://cr.openjdk.java.net/~hseigel/bug_jdk7195622.0/
The changes looks good.
There are some changes that I don't fully agree with, but I will not
block the push because of them. I'm just going to
On 09/20/2013 02:46 PM, Stefan Karlsson wrote:
On 09/19/2013 05:13 PM, Lois Foltan wrote:
Please review the following fix:
Webrev:
http://cr.openjdk.java.net/~hseigel/bug_jdk7195622.0/
The changes looks good.
I forgot this rather benign bug:
On 9/20/2013 9:16 AM, Stefan Karlsson wrote:
On 09/20/2013 02:46 PM, Stefan Karlsson wrote:
On 09/19/2013 05:13 PM, Lois Foltan wrote:
Please review the following fix:
Webrev:
http://cr.openjdk.java.net/~hseigel/bug_jdk7195622.0/
The changes looks good.
I forgot this rather benign
Please review the following fix:
Webrev:
http://cr.openjdk.java.net/~hseigel/bug_jdk7195622.0/
Bug: JDK8 b44 hotspot:src/share/vm/oops/klass.hpp: Error:Initializing
const volatile oop requires ...
CheckUnhandledOops has limited usefulness now bug links at:
Please review the following fix:
Webrev:
http://cr.openjdk.java.net/~hseigel/bug_jdk7195622.0/
Bug: JDK8 b44 hotspot:src/share/vm/oops/klass.hpp: Error:Initializing
const volatile oop requires ...
CheckUnhandledOops has limited usefulness now bug links at:
Please review the following fix:
Webrev:
http://cr.openjdk.java.net/~hseigel/bug_jdk7195622.0/
Bug: JDK8 b44 hotspot:src/share/vm/oops/klass.hpp: Error:Initializing
const volatile oop requires ...
CheckUnhandledOops has limited usefulness now bug links at:
Lois,
This looks really good! Thank you for enabling this on all the
platforms so we can use this checking everywhere.
Thanks,
Coleen
On 09/19/2013 11:10 AM, Lois Foltan wrote:
Please review the following fix:
Webrev:
http://cr.openjdk.java.net/~hseigel/bug_jdk7195622.0/
Bug: JDK8
On Sep 19, 2013, at 3:19 PM, Lois Foltan lois.fol...@oracle.com wrote:
On 9/19/2013 6:09 PM, Christian Thalinger wrote:
+ #define CAST_TO_OOP(value) ((oop)(CHECK_UNHANDLED_OOPS_ONLY((void
*))(value)))
+ #define CAST_FROM_OOP(new_type, value)
((new_type)(CHECK_UNHANDLED_OOPS_ONLY((void
+ #define CAST_TO_OOP(value) ((oop)(CHECK_UNHANDLED_OOPS_ONLY((void *))(value)))
+ #define CAST_FROM_OOP(new_type, value)
((new_type)(CHECK_UNHANDLED_OOPS_ONLY((void *))(value)))
Could these two macros also be a method?
On Sep 19, 2013, at 8:13 AM, Lois Foltan lois.fol...@oracle.com wrote:
On 9/19/2013 6:09 PM, Christian Thalinger wrote:
+ #define CAST_TO_OOP(value) ((oop)(CHECK_UNHANDLED_OOPS_ONLY((void *))(value)))
+ #define CAST_FROM_OOP(new_type, value)
((new_type)(CHECK_UNHANDLED_OOPS_ONLY((void *))(value)))
Could these two macros also be a method?
Hi Christian,
I assume
On 9/19/2013 6:27 PM, Christian Thalinger wrote:
On Sep 19, 2013, at 3:19 PM, Lois Foltan lois.fol...@oracle.com wrote:
On 9/19/2013 6:09 PM, Christian Thalinger wrote:
+ #define CAST_TO_OOP(value) ((oop)(CHECK_UNHANDLED_OOPS_ONLY((void *))(value)))
+ #define CAST_FROM_OOP(new_type, value)
On Sep 19, 2013, at 4:22 PM, Lois Foltan lois.fol...@oracle.com wrote:
On 9/19/2013 6:27 PM, Christian Thalinger wrote:
On Sep 19, 2013, at 3:19 PM, Lois Foltan lois.fol...@oracle.com wrote:
On 9/19/2013 6:09 PM, Christian Thalinger wrote:
+ #define CAST_TO_OOP(value)
On 9/19/2013 7:25 PM, Christian Thalinger wrote:
On Sep 19, 2013, at 4:22 PM, Lois Foltan lois.fol...@oracle.com wrote:
On 9/19/2013 6:27 PM, Christian Thalinger wrote:
On Sep 19, 2013, at 3:19 PM, Lois Foltan lois.fol...@oracle.com wrote:
On 9/19/2013 6:09 PM, Christian Thalinger wrote:
On Sep 19, 2013, at 6:06 PM, Lois Foltan lois.fol...@oracle.com wrote:
On 9/19/2013 7:25 PM, Christian Thalinger wrote:
On Sep 19, 2013, at 4:22 PM, Lois Foltan lois.fol...@oracle.com wrote:
On 9/19/2013 6:27 PM, Christian Thalinger wrote:
On Sep 19, 2013, at 3:19 PM, Lois Foltan
19 matches
Mail list logo
