(adding build-dev as well)
On 2015-11-03, Volker Simonis wrote:
> Hi Erik,
>
> while I agree that this is a nice clean up I want to second Thomas in
> his attempt to save the VS 2010 build. I understand that the official
> Oracle build tool chain for jdk9 on Windows is VS 2013, but this may
> be
On Wed, Nov 4, 2015 at 11:46 AM, Erik Helin wrote:
> (adding build-dev as well)
>
> On 2015-11-03, Volker Simonis wrote:
>> Hi Erik,
>>
>> while I agree that this is a nice clean up I want to second Thomas in
>> his attempt to save the VS 2010 build. I understand that the official
>> Oracle build
Hi Eric,
On Wed, Nov 4, 2015 at 11:46 AM, Erik Helin wrote:
> (adding build-dev as well)
>
> On 2015-11-03, Volker Simonis wrote:
> > Hi Erik,
> >
> > while I agree that this is a nice clean up I want to second Thomas in
> > his attempt to save the VS 2010 build. I understand that the official
>
On 2015-11-04 11:46, Erik Helin wrote:
Maybe we can come up with something that removes these #pragmas from the
GC code while still allowing you to compile with VS2010. What do you
think about the following suggestions:
- We change the Makefiles to add the flag /Wd4355 if we use VS2010 or
old
Hi Thomas,
the change looks good. Thomas St. is just checking the VS2010 build.
We'll let you new the results once it's finished.
Thank you and best regards,
Volker
On Wed, Nov 4, 2015 at 4:04 PM, Erik Helin wrote:
> On 2015-11-04, Thomas Schatzl wrote:
>> Hi,
>>
>> On Wed, 2015-11-04 at 12:12
Hi Eric,
your change builds fine on VS 2010.
Thank you!
Thomas
On Wed, Nov 4, 2015 at 4:04 PM, Erik Helin wrote:
> On 2015-11-04, Thomas Schatzl wrote:
> > Hi,
> >
> > On Wed, 2015-11-04 at 12:12 +0100, Volker Simonis wrote:
> > > Hi Erik,
> > >
> > > thanks a lot for your understanding :)
>
On 2015-11-04, Thomas Schatzl wrote:
> Hi,
>
> On Wed, 2015-11-04 at 12:12 +0100, Volker Simonis wrote:
> > Hi Erik,
> >
> > thanks a lot for your understanding :)
> >
> > Your suggestion is perfectly fine for me and we can live with both
> > versions of the fix.
>
> I went for the change in
Hi,
On Wed, 2015-11-04 at 12:12 +0100, Volker Simonis wrote:
> Hi Erik,
>
> thanks a lot for your understanding :)
>
> Your suggestion is perfectly fine for me and we can live with both
> versions of the fix.
I went for the change in the globalDefinitions* file.
New webrevs:
http://cr.openj
