Re: RFR (xs): 8238515 - Backout JDK-8236092 from jdk/jdk

2020-02-04 Thread Jesper Wilhelmsson
Thank you David! /Jesper > On 5 Feb 2020, at 03:37, David Holmes wrote: > > Looks good and trivial. > > Thanks, > David > > On 5/02/2020 12:36 pm, Jesper Wilhelmsson wrote: >> Hi. >> I need a review for this tiny change. >> The "ea" suffix was removed from the JDK 14 version string with

Re: RFR (xs): 8238515 - Backout JDK-8236092 from jdk/jdk

2020-02-04 Thread Jesper Wilhelmsson
Thank you Tim! /Jesper > On 5 Feb 2020, at 03:40, Tim Bell wrote: > > Jesper: > > Looks good to me as well. > > Tim > > On 2/4/20 6:37 PM, David Holmes wrote: >> Looks good and trivial. >> Thanks, >> David >> On 5/02/2020 12:36 pm, Jesper Wilhelmsson wrote: >>> Hi. >>> >>> I need a review

Re: RFR (xs): 8238515 - Backout JDK-8236092 from jdk/jdk

2020-02-04 Thread Tim Bell
Jesper: Looks good to me as well. Tim On 2/4/20 6:37 PM, David Holmes wrote: Looks good and trivial. Thanks, David On 5/02/2020 12:36 pm, Jesper Wilhelmsson wrote: Hi. I need a review for this tiny change. The "ea" suffix was removed from the JDK 14 version string with JDK-8236092. Since

RFR (xs): 8238515 - Backout JDK-8236092 from jdk/jdk

2020-02-04 Thread Jesper Wilhelmsson
Hi. I need a review for this tiny change. The "ea" suffix was removed from the JDK 14 version string with JDK-8236092. Since that change is forwardported to jdk/jdk I need to back it out there. This is the backout diff as created by hg backout: diff --git a/make/autoconf/version-numbers

Re: RFR (xs): 8238515 - Backout JDK-8236092 from jdk/jdk

2020-02-04 Thread David Holmes
Looks good and trivial. Thanks, David On 5/02/2020 12:36 pm, Jesper Wilhelmsson wrote: Hi. I need a review for this tiny change. The "ea" suffix was removed from the JDK 14 version string with JDK-8236092. Since that change is forwardported to jdk/jdk I need to back it out there. This is the