Re: RFR [JEP 220] Modular Run-Time Images - fix zero build

2014-12-04 Thread Xerxes RĂ„nby
Hi Chris! The build changes introduced a new dependency that sa-jdi.jar is always built. The sa-jdi.jar do not get built for Zero and Itanium builds. Zero is built using the --with-jvm-interpreter=cpp --with-jvm-variants=zero configure options. The sa-jdi.jar also do not exist if you use

Re: RFR [JEP 220] Modular Run-Time Images - fix zero build

2014-12-03 Thread Erik Joelsson
Hello Xerxes, Thanks for the suggestion. I have created https://bugs.openjdk.java.net/browse/JDK-8066589 to track this issue. Unfortunately we won't have time to fix it before pushing JEP 220 to jdk9. I hope this won't inconvenience you too much. Your suggested patch does correctly

Re: RFR [JEP 220] Modular Run-Time Images - fix zero build

2014-12-03 Thread Dave Pointon
Hmmm , Would it not be possible to modify Xerxes' suggested patch to do something along the lines of ... # sa-jdi.jar do not exist for Itanium and zero ifeq ($(shell if test -a $(HOTSPOT_DIST)/lib/sa-jdi.jar; then echo N; fi),N) SA_TARGETS += \

Re: RFR [JEP 220] Modular Run-Time Images - fix zero build

2014-12-03 Thread Erik Joelsson
Yes, it can be modified. My preferred variant for file existence checking in make is ifneq ($(wildcard /path/to/file), ). Also, in Gensrc-jdk.jdi.gmk, I would probably like some other logical condition to check on than sa-jdi.jar. We will address this at some point soon. /Erik On 2014-12-03

Re: RFR [JEP 220] Modular Run-Time Images - fix zero build

2014-12-03 Thread Dave Pointon
Yep , I like that even more, Erik :-) -- Dave Pointon FIAP MBCS Now I saw, tho' too late, the folly of beginning a work before we count the cost and before we we judge rightly of our strength to go thro' with it - Robinson Crusoe On 3 December 2014 at 17:46, Erik Joelsson