hias ; Magnus Ihse Bursie
>>>
>>> Cc: build-dev@openjdk.java.net
>>> Subject: Re: RFR [XS]: 8208744: remove unneeded -DUSE_MMAP settings for
>>> JDK native libs builds -was : RE: unneeded -DUSE_MMAP in JDK native libs
>>> builds
>>>
>
Looks good to me.
On Fri, Aug 3, 2018 at 5:58 AM, Alan Bateman
wrote:
>
>
> On 03/08/2018 00:21, David Holmes wrote:
>
>> On 3/08/2018 4:59 PM, Baesken, Matthias wrote:
>>
>>> Thank you David , can the change be pushed , or do I need a second
>>> review for an XS change ?
>>> (any way a sec
On 03/08/2018 00:21, David Holmes wrote:
On 3/08/2018 4:59 PM, Baesken, Matthias wrote:
Thank you David , can the change be pushed , or do I need a
second review for an XS change ?
(any way a second review would be good 😊 )
Need a review from official build team member :)
I'm not in t
-Original Message-
From: David Holmes
Sent: Freitag, 3. August 2018 08:18
To: Baesken, Matthias ; Magnus Ihse Bursie
Cc: build-dev@openjdk.java.net
Subject: Re: RFR [XS]: 8208744: remove unneeded -DUSE_MMAP settings for
JDK native libs builds -was : RE: unneeded -DUSE_MMAP in JDK native libs
builds
Magnus Ihse Bursie
>
> Cc: build-dev@openjdk.java.net
> Subject: Re: RFR [XS]: 8208744: remove unneeded -DUSE_MMAP settings for
> JDK native libs builds -was : RE: unneeded -DUSE_MMAP in JDK native libs
> builds
>
> Looks fine to me.
>
> Thanks,
> David
>
&g
Looks fine to me.
Thanks,
David
On 3/08/2018 4:13 PM, Baesken, Matthias wrote:
Hello, I can confirm what David said .
Additionally I grepped through /usr/include on my Linux machine and did not
find any USE_MMAP occurences.
I created this webrev + bug :
http://cr.openjdk.java.net/~mbaes
Hello, I can confirm what David said .
Additionally I grepped through /usr/include on my Linux machine and did not
find any USE_MMAP occurences.
I created this webrev + bug :
http://cr.openjdk.java.net/~mbaesken/webrevs/8208744/
https://bugs.openjdk.java.net/browse/JDK-8208744
Please re
