Re: RFR 8030011: Update Hotspot version string output

2014-04-24 Thread Alejandro E Murillo
On 4/24/2014 2:52 PM, John Coomes wrote: Alejandro E Murillo (alejandro.muri...@oracle.com) wrote: ... I think I incorporated all the changes David, John and you suggested and started some sanity testing; Here's is the latest webrev: http://cr.openjdk.java.net/~amurillo/9/8030011/ Please revi

Re: RFR 8030011: Update Hotspot version string output

2014-04-24 Thread John Coomes
Alejandro E Murillo (alejandro.muri...@oracle.com) wrote: > ... > I think I incorporated all the changes David, John and you suggested and > started some sanity testing; > Here's is the latest webrev: > > http://cr.openjdk.java.net/~amurillo/9/8030011/ > > Please review (don't forget to refresh

Re: RFR 8030011: Update Hotspot version string output

2014-04-24 Thread Alejandro E Murillo
Thanks Vladimir Alejandro On 4/23/2014 11:53 AM, Vladimir Kozlov wrote: Looks good. Thanks, Vladimir On 4/22/14 7:32 PM, Alejandro E Murillo wrote: On 4/22/2014 6:12 PM, Vladimir Kozlov wrote: On 4/22/14 4:42 PM, Alejandro E Murillo wrote: On 4/21/2014 1:18 PM, Vladimir Kozlov wrote: Hi

Re: RFR 8030011: Update Hotspot version string output

2014-04-23 Thread Vladimir Kozlov
Looks good. Thanks, Vladimir On 4/22/14 7:32 PM, Alejandro E Murillo wrote: On 4/22/2014 6:12 PM, Vladimir Kozlov wrote: On 4/22/14 4:42 PM, Alejandro E Murillo wrote: On 4/21/2014 1:18 PM, Vladimir Kozlov wrote: Hi Alejandro, I don't think we need to rename make/hotspot_version file. It

Re: RFR 8030011: Update Hotspot version string output

2014-04-22 Thread Alejandro E Murillo
On 4/22/2014 6:12 PM, Vladimir Kozlov wrote: On 4/22/14 4:42 PM, Alejandro E Murillo wrote: On 4/21/2014 1:18 PM, Vladimir Kozlov wrote: Hi Alejandro, I don't think we need to rename make/hotspot_version file. It is still used to set JVM's version string and not JDK's version. Next asser

Re: RFR 8030011: Update Hotspot version string output

2014-04-22 Thread Vladimir Kozlov
On 4/22/14 4:42 PM, Alejandro E Murillo wrote: On 4/21/2014 1:18 PM, Vladimir Kozlov wrote: Hi Alejandro, I don't think we need to rename make/hotspot_version file. It is still used to set JVM's version string and not JDK's version. Next assert message is not consistent with previous messa

Re: RFR 8030011: Update Hotspot version string output

2014-04-22 Thread Alejandro E Murillo
On 4/21/2014 1:18 PM, Vladimir Kozlov wrote: Hi Alejandro, I don't think we need to rename make/hotspot_version file. It is still used to set JVM's version string and not JDK's version. Next should be 2014 (I think David pointed it too but there is no new webrev): HOTSPOT_VM_COPYRIGHT=Cop

Re: RFR 8030011: Update Hotspot version string output

2014-04-21 Thread Vladimir Kozlov
Hi Alejandro, I don't think we need to rename make/hotspot_version file. It is still used to set JVM's version string and not JDK's version. Next should be 2014 (I think David pointed it too but there is no new webrev): HOTSPOT_VM_COPYRIGHT=Copyright 2013 If you pass major, micro etc number

Re: RFR 8030011: Update Hotspot version string output

2014-04-21 Thread Alejandro E Murillo
On 4/18/2014 6:50 PM, John Coomes wrote: Alejandro E Murillo (alejandro.muri...@oracle.com) wrote: Please review this change to make the hotspot related output produced by "java -version" match the corresponding JDK output: webrev: http://cr.openjdk.java.net/~amurillo/9/8030011/ Bug: https://b

Re: RFR 8030011: Update Hotspot version string output

2014-04-18 Thread John Coomes
Alejandro E Murillo (alejandro.muri...@oracle.com) wrote: > > Please review this change to make the hotspot related output produced by > "java -version" > match the corresponding JDK output: > > webrev: http://cr.openjdk.java.net/~amurillo/9/8030011/ > Bug: https://bugs.openjdk.java.net/browse/J

Re: RFR 8030011: Update Hotspot version string output

2014-04-11 Thread alejandro murillo
On 4/10/2014 8:11 PM, David Holmes wrote: On 11/04/2014 1:42 AM, Alejandro E Murillo wrote: Hi David, thanks for the feedback, see below On 4/9/2014 8:38 PM, David Holmes wrote: Hi Alejandro, Given we have to maintain the JDK version information in two places (top level repo and hotspot repo)

Re: RFR 8030011: Update Hotspot version string output

2014-04-10 Thread David Holmes
On 11/04/2014 1:42 AM, Alejandro E Murillo wrote: Hi David, thanks for the feedback, see below On 4/9/2014 8:38 PM, David Holmes wrote: Hi Alejandro, Given we have to maintain the JDK version information in two places (top level repo and hotspot repo) wouldn't it have been simpler to keep hotsp

Re: RFR 8030011: Update Hotspot version string output

2014-04-10 Thread Alejandro E Murillo
Hi David, thanks for the feedback, see below On 4/9/2014 8:38 PM, David Holmes wrote: Hi Alejandro, Given we have to maintain the JDK version information in two places (top level repo and hotspot repo) wouldn't it have been simpler to keep hotspot_version file and HOTSPOT_RELEASE_VERSION and s

Re: RFR 8030011: Update Hotspot version string output

2014-04-09 Thread David Holmes
Hi Alejandro, Given we have to maintain the JDK version information in two places (top level repo and hotspot repo) wouldn't it have been simpler to keep hotspot_version file and HOTSPOT_RELEASE_VERSION and simply set the major/minor/build values to match those of the JDK version? That aside

RFR 8030011: Update Hotspot version string output

2014-04-09 Thread Alejandro E Murillo
Please review this change to make the hotspot related output produced by "java -version" match the corresponding JDK output: webrev: http://cr.openjdk.java.net/~amurillo/9/8030011/ Bug: https://bugs.openjdk.java.net/browse/JDK-8030011 Note that we initially wanted to obtain more information f