Re: RFR 15 8225319: Remove the RMI static stub compiler rmic

2020-04-06 Thread Alan Bateman
On 03/04/2020 16:43, Roger Riggs wrote: Please review the CSR[1] and changes to remove the RMI static stub compiler (rmic). RMIC was deprecated for removal in JDK 13 [3]. The components modified are:  - remove the jdk.rmic module  - remove the jdk.rmic man page  - remove all tests of rmic or

Re: RFR 15 8225319: Remove the RMI static stub compiler rmic

2020-04-06 Thread Amy Lu
Hi, Roger I noticed some other minor cleanup needed, will they be included in this fix, or separately in the future? 1. test/jdk/TEST.groups To remove `sun/tools/java` from core_tools and svc_tools group. (The only one test under `sun/tools/java` got removed in this patch.) 2. doc/building.

Re: RFR 15 8225319: Remove the RMI static stub compiler rmic

2020-04-03 Thread Erik Joelsson
Looks good. /Erik On 2020-04-03 08:43, Roger Riggs wrote: Please review the CSR[1] and changes to remove the RMI static stub compiler (rmic). RMIC was deprecated for removal in JDK 13 [3]. The components modified are:  - remove the jdk.rmic module  - remove the jdk.rmic man page  - remove all

Re: RFR 15 8225319: Remove the RMI static stub compiler rmic

2020-04-03 Thread Lance Andersen
Hi Roger, This looks good and brought back memories of removing the Java EE modules :-) Best Lance > On Apr 3, 2020, at 11:43 AM, Roger Riggs wrote: > > Please review the CSR[1] and changes to remove the RMI static stub compiler > (rmic). > RMIC was deprecated for removal in JDK 13 [3]. > >

RFR 15 8225319: Remove the RMI static stub compiler rmic

2020-04-03 Thread Roger Riggs
Please review the CSR[1] and changes to remove the RMI static stub compiler (rmic). RMIC was deprecated for removal in JDK 13 [3]. The components modified are:  - remove the jdk.rmic module  - remove the jdk.rmic man page  - remove all tests of rmic or relying on rmic  - update or remove makefil