On 23/10/2013 10:12, Magnus Ihse Bursie wrote:
Just to be clear: looks good to me, too.
Thanks Magnus.
-Chris.
/Magnus
23 okt 2013 kl. 11:00 skrev Chris Hegarty:
On 23/10/2013 09:15, Erik Joelsson wrote:
I approve the change.
Thanks Erik.
Perhaps a one line comment explaining why th
Perfect, thanks.
/Erik
On 2013-10-23 11:00, Chris Hegarty wrote:
On 23/10/2013 09:15, Erik Joelsson wrote:
I approve the change.
Thanks Erik.
Perhaps a one line comment explaining why this exception is needed is
warranted?
To close the review loop, the final change will look like:
diff
Just to be clear: looks good to me, too.
/Magnus
23 okt 2013 kl. 11:00 skrev Chris Hegarty :
> On 23/10/2013 09:15, Erik Joelsson wrote:
>> I approve the change.
>
> Thanks Erik.
>
>> Perhaps a one line comment explaining why this exception is needed is
>> warranted?
>
> To close the review l
On 23/10/2013 09:15, Erik Joelsson wrote:
I approve the change.
Thanks Erik.
Perhaps a one line comment explaining why this exception is needed is
warranted?
To close the review loop, the final change will look like:
diff --git a/makefiles/lib/NioLibraries.gmk b/makefiles/lib/NioLibraries.
On 22/10/2013 22:05, Magnus Ihse Bursie wrote:
On 2013-10-22 20:44, Chris Hegarty wrote:
The SCTP native code complies with -Werror. gcc 4.8.1 reports unused
parameters as warnings, and this causes the build to fail. gcc 4.8.1
is the defaul on Ubuntu 13.10.
An alternative solution is to keep t
I approve the change.
Perhaps a one line comment explaining why this exception is needed is
warranted?
/Erik
On 2013-10-22 20:44, Chris Hegarty wrote:
The SCTP native code complies with -Werror. gcc 4.8.1 reports unused
parameters as warnings, and this causes the build to fail. gcc 4.8.1
is
On 2013-10-22 20:44, Chris Hegarty wrote:
The SCTP native code complies with -Werror. gcc 4.8.1 reports unused
parameters as warnings, and this causes the build to fail. gcc 4.8.1
is the defaul on Ubuntu 13.10.
An alternative solution is to keep the warning but fix the code.
The traditional s
> On 22 Oct 2013, at 20:19, Mike Duigou wrote:
>
> This is the same change I am using locally. It wasn't clear why the SCTP
> handling of errors was different than the rest of the libs.
The SCTP native code is clean enough to enable Werror, not sure if others areas
are but they certainly do n
I was also stuck in this build issue when working with the new gcc in
Ubuntu. Thanks for fixing the issue, Chris.
The change looks good to me.
-Dan
On 10/22/2013 11:44 AM, Chris Hegarty wrote:
The SCTP native code complies with -Werror. gcc 4.8.1 reports unused
parameters as warnings, and th
This is the same change I am using locally. It wasn't clear why the SCTP
handling of errors was different than the rest of the libs.
Mike
On Oct 22 2013, at 11:44 , Chris Hegarty wrote:
> The SCTP native code complies with -Werror. gcc 4.8.1 reports unused
> parameters as warnings, and this c
The SCTP native code complies with -Werror. gcc 4.8.1 reports unused
parameters as warnings, and this causes the build to fail. gcc 4.8.1 is
the defaul on Ubuntu 13.10.
These parameters are required as the functions are JNI functions. The
simplest solution is to ignore/suppress these unused pa
11 matches
Mail list logo
