Re: RFR 8066146: jdk.nashorn.api.scripting package javadoc should be included in jdk docs

2014-11-28 Thread Mandy Chung
Hi Sundar, On 11/28/2014 2:41 AM, A. Sundararajan wrote: Hi, Please review http://cr.openjdk.java.net/~sundar/8066146/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8066146 Is jdk.nashorn.api.scripting a supported API? It looks like some classes are defined for JEP 202 [1] and is

Re: RFR 8066146: jdk.nashorn.api.scripting package javadoc should be included in jdk docs

2014-11-28 Thread Magnus Ihse Bursie
On 2014-11-28 11:41, A. Sundararajan wrote: Hi, Please review http://cr.openjdk.java.net/~sundar/8066146/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8066146 Thanks, -Sundar Is it by intention that you do not add $(NASHORNAPI_PKGS) to NON_CORE_PKGS? /Magnus

Re: RFR 8066146: jdk.nashorn.api.scripting package javadoc should be included in jdk docs

2014-11-28 Thread Marcus Lagergren
+1 > On 28 Nov 2014, at 12:50, A. Sundararajan > wrote: > > Hi, > > Thanks for catching that! > > Please review updated http://cr.openjdk.java.net/~sundar/8066146/webrev.01/ > > Thanks, > -Sundar > > Erik Joelsson wrote: >> Hello, >> >> Should: >> >> 1140 NASHORNAPI2COREAPI := ../../$(JD

Re: RFR 8066146: jdk.nashorn.api.scripting package javadoc should be included in jdk docs

2014-11-28 Thread Jim Laskey (Oracle)
+1 On Nov 28, 2014, at 6:41 AM, A. Sundararajan wrote: > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8066146/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8066146 > > Thanks, > -Sundar

Re: RFR 8066146: jdk.nashorn.api.scripting package javadoc should be included in jdk docs

2014-11-28 Thread Erik Joelsson
Looks good to me. /Erik On 2014-11-28 12:50, A. Sundararajan wrote: Hi, Thanks for catching that! Please review updated http://cr.openjdk.java.net/~sundar/8066146/webrev.01/ Thanks, -Sundar Erik Joelsson wrote: Hello, Should: 1140 NASHORNAPI2COREAPI := ../../$(JDKJRE2COREAPI) be? 114

Re: RFR 8066146: jdk.nashorn.api.scripting package javadoc should be included in jdk docs

2014-11-28 Thread A. Sundararajan
Hi, Thanks for catching that! Please review updated http://cr.openjdk.java.net/~sundar/8066146/webrev.01/ Thanks, -Sundar Erik Joelsson wrote: Hello, Should: 1140 NASHORNAPI2COREAPI := ../../$(JDKJRE2COREAPI) be? 1140 NASHORNAPI2COREAPI := ../$(JDKJRE2COREAPI) I assume it's relative to

Re: RFR 8066146: jdk.nashorn.api.scripting package javadoc should be included in jdk docs

2014-11-28 Thread Erik Joelsson
Hello, Should: 1140 NASHORNAPI2COREAPI := ../../$(JDKJRE2COREAPI) be? 1140 NASHORNAPI2COREAPI := ../$(JDKJRE2COREAPI) I assume it's relative to DOCDIR defined on the line above. /Erik On 2014-11-28 11:41, A. Sundararajan wrote: Hi, Please review http://cr.openjdk.java.net/~sundar/8066146/

RFR 8066146: jdk.nashorn.api.scripting package javadoc should be included in jdk docs

2014-11-28 Thread A. Sundararajan
Hi, Please review http://cr.openjdk.java.net/~sundar/8066146/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8066146 Thanks, -Sundar