Much better, and thank you for fixing the existing mkdir/echo lines too.
Just one nit, for this continuation:
$(TOOL_CACERTSHASHER) -i $(GENDATA_CACERTSHASHER_IN) \
-o $(GENDATA_CACERTSHASHER)
please use tab+4spaces for the second line. No need to resend webrev for
that. See [
I believe I got everyone's comments. I've updated the webrev.
http://cr.openjdk.java.net/~ascarpino/8140422/webrev.02/
Thanks
Tony
On 02/29/2016 08:55 AM, Anthony Scarpino wrote:
Currently CertPath algorithm restrictions allow or deny all
certificates. This change adds the ability to reject
Ok.. thanks.. I'll make those changes..
Tony
On 03/12/2016 07:37 AM, Erik Joelsson wrote:
Hello Anthony,
I realize you followed the patterns already in the file and we
apparently haven't updated that file to follow latest standards. I would
like you to change the following:
$(ECHO) foo
ok.. thanks
Tony
On 03/18/2016 10:27 AM, Erik Joelsson wrote:
Much better, and thank you for fixing the existing mkdir/echo lines too.
Just one nit, for this continuation:
$(TOOL_CACERTSHASHER) -i $(GENDATA_CACERTSHASHER_IN) \
-o $(GENDATA_CACERTSHASHER)
please use tab+4spa
Hello Anthony,
I realize you followed the patterns already in the file and we
apparently haven't updated that file to follow latest standards. I would
like you to change the following:
$(ECHO) foo
should be
$(call LogInfo, foo)
and
$(MKDIR) -p foo
should be
$(call MakeDi
I updated the webrev and added the build-dev list as there are two
makefile changes.
http://cr.openjdk.java.net/~ascarpino/8140422/webrev.01/
thanks
Tony
On 02/29/2016 08:55 AM, Anthony Scarpino wrote:
I need a code review of this change:
Currently CertPath algorithm restrictions allow or
