Re: RFR 8148187 : Remove OS X-specific com.apple.concurrent package

2016-03-02 Thread Alan Bateman
On 01/03/2016 21:16, Brent Christian wrote: For your review is a webrev of this change: http://cr.openjdk.java.net/~bchristi/8148187/webrev.01/ This looks good to me, in particular the move of FileManager.m into the right source tree as it was just wrong for that to be in jdk.deploy.osx when

Re: RFR 8148187 : Remove OS X-specific com.apple.concurrent package

2016-03-01 Thread Erik Joelsson
Hello Brent, The build changes look pretty good. Just one nit, in the new LibosxLibraries.gmk, please remove the "include LibCommon.gmk" as that is now handled by Lib-java.desktop.gmk. /Erik On 2016-03-01 22:16, Brent Christian wrote: Hi, A number of internal APIs were carried over into th

Re: RFR 8148187 : Remove OS X-specific com.apple.concurrent package

2016-03-01 Thread Mandy Chung
> On Mar 1, 2016, at 1:16 PM, Brent Christian > wrote: > > Hi, > > A number of internal APIs were carried over into the JDK with the Apple port. > Among them was com.apple.concurrent.Dispatch. > > Supportedness has always been murky here, but Jigsaw necessitates a firmer > stance. Some of

RFR 8148187 : Remove OS X-specific com.apple.concurrent package

2016-03-01 Thread Brent Christian
Hi, A number of internal APIs were carried over into the JDK with the Apple port. Among them was com.apple.concurrent.Dispatch. Supportedness has always been murky here, but Jigsaw necessitates a firmer stance. Some of these APIs have already been removed from JDK 9 [1], some will be suppl