Looks ok to me (and same caveat as Magnus).
/Erik
On 2018-08-31 06:59, Maurizio Cimadamore wrote:
Thanks for the reviews; once again, when doing some more testing I
discovered some issues which had to do with coexistence with the
intellij jtreg plugin.
The bottom of the issue is that certai
Thanks for the reviews; once again, when doing some more testing I
discovered some issues which had to do with coexistence with the
intellij jtreg plugin.
The bottom of the issue is that certain IDE owned ant variable (such as
$ModuleFileDir$) are only set when clicking on certain IDE actions,
On 2018-08-30 17:12, Maurizio Cimadamore wrote:
Hi,
this patch adds proper support for -o option to the idea.sh script,
which allows to place the .idea folder under any given output folder
(not necessarily the JDK root).
To be able to do this, I had to revampo the logic for template
substitu
Looks good to me.
/Erik
On 2018-08-30 08:12, Maurizio Cimadamore wrote:
Hi,
this patch adds proper support for -o option to the idea.sh script,
which allows to place the .idea folder under any given output folder
(not necessarily the JDK root).
To be able to do this, I had to revampo the l
Hi,
this patch adds proper support for -o option to the idea.sh script,
which allows to place the .idea folder under any given output folder
(not necessarily the JDK root).
To be able to do this, I had to revampo the logic for template
substitution in idea.sh, as it was growing too brittle. I
