Looks good to me, too.
/Magnus
> 4 dec. 2018 kl. 20:34 skrev Mandy Chung :
>
> The revised webrev looks okay.
>
> Mandy
>
>> On 12/4/18 11:32 AM, Roger Riggs wrote:
>> Hi Mandy, Martin,
>>
>> The new test is unnecessary, the case is covered by
>> java/lang/System/Versions test
>> and uses t
>
> LGTM
Looks good.
/Erik
On 2018-12-04 11:32, Roger Riggs wrote:
Hi Mandy, Martin,
The new test is unnecessary, the case is covered by
java/lang/System/Versions test
and uses the stronger comparison for the version numbers.
It would not detect the problem unless the version included more than
the
Hi Mandy, Martin,
The new test is unnecessary, the case is covered by
java/lang/System/Versions test
and uses the stronger comparison for the version numbers.
It would not detect the problem unless the version included more than
the major version.
Webrev: http://cr.openjdk.java.net/~rriggs/
The revised webrev looks okay.
Mandy
On 12/4/18 11:32 AM, Roger Riggs wrote:
Hi Mandy, Martin,
The new test is unnecessary, the case is covered by
java/lang/System/Versions test
and uses the stronger comparison for the version numbers.
It would not detect the problem unless the version incl
Hi Roger,
Looks fine.
Brian
> On Dec 4, 2018, at 8:23 AM, Roger Riggs wrote:
>
> Including build-dev for the change to GensrcMisc.gmk.
>
> thx.
>
> On 12/04/2018 11:16 AM, Roger Riggs wrote:
>> Please review correctly setting the java.specification.version property
>> with only the major ver
On 12/4/18 8:16 AM, Roger Riggs wrote:
Please review correctly setting the java.specification.version property
with only the major version number. A test is added to ensure the
java spec version agrees with the major version.
The symptoms are that jtreg would fail with a full version number.
Including build-dev for the change to GensrcMisc.gmk.
thx.
On 12/04/2018 11:16 AM, Roger Riggs wrote:
Please review correctly setting the java.specification.version property
with only the major version number. A test is added to ensure the
java spec version agrees with the major version.
The